ios/web/web_state/ui/crw_wk_web_view_web_controller.h - Issue 1874903003: Reversed WebState <-> CRWWebController ownership.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/crw_wk_web_view_web_controller.h

Issue 1874903003: Reversed WebState <-> CRWWebController ownership. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Self review Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/ui/crw_wk_web_view_web_controller.h

diff --git a/ios/web/web_state/ui/crw_wk_web_view_web_controller.h b/ios/web/web_state/ui/crw_wk_web_view_web_controller.h

index 44eef2d244a67de12e78ceaae449282716affcc0..cde01616b82be8046d200f074935e66e1b9b9ed7 100644

--- a/ios/web/web_state/ui/crw_wk_web_view_web_controller.h

+++ b/ios/web/web_state/ui/crw_wk_web_view_web_controller.h

@@ -12,8 +12,8 @@

// A concrete implementation of CRWWebController based on WKWebView.

@interface CRWWKWebViewWebController : CRWWebController

-// Designated initializer.

-- (instancetype)initWithWebState:(std::unique_ptr<web::WebStateImpl>)webState;

+// Designated initializer. Initializes web controller with unowned |webState|.

kkhorimoto 2016/04/12 21:36:13 Same here. Specifying which object owns what is c

Eugene But (OOO till 7-30) 2016/04/13 02:51:26 Specifying the owner is a layering violation or ev

Eugene But (OOO till 7-30) 2016/04/13 13:57:58 Updated the comments according to Rohit's suggesti

+- (instancetype)initWithWebState:(web::WebStateImpl*)webState;

@end