Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1873313002: Convert some unit tests from running on GL contexts to running on all contexts (Closed)

Created:
4 years, 8 months ago by bsalomon
Modified:
4 years, 8 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@vkcfg
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M dm/DM.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GpuColorFilterTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GrDrawTargetTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/TessellatingPathRendererTests.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/Test.h View 1 chunk +12 lines, -10 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
bsalomon
I tried all the tests that use the DEF_GPUTEST_FOR_ALL_GL_CONTEXTS macro and these are the ones ...
4 years, 8 months ago (2016-04-11 20:41:58 UTC) #3
egdaniel
lgtm
4 years, 8 months ago (2016-04-11 20:54:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873313002/1
4 years, 8 months ago (2016-04-11 21:27:55 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 21:40:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fda880710c28a1b0ff0c8c88f90a7659a7ce553f

Powered by Google App Engine
This is Rietveld 408576698