dm/DM.cpp - Issue 1873313002: Convert some unit tests from running on GL contexts to running on all contexts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dm/DM.cpp

Issue 1873313002: Convert some unit tests from running on GL contexts to running on all contexts (Closed) Base URL: https://skia.googlesource.com/skia.git@vkcfg

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dm/DM.cpp

diff --git a/dm/DM.cpp b/dm/DM.cpp

index fd06bc06608babca279f714d2b093ee13cec55b3..388546d66fcf23c309634bc0f43d5fbb5d7db101 100644

--- a/dm/DM.cpp

+++ b/dm/DM.cpp

@@ -1442,7 +1442,7 @@ void RunWithGPUTestContexts(GrContextTestFn* test, GrContextTypeFilterFn* contex

for (int typeInt = 0; typeInt < GrContextFactory::kContextTypeCnt; ++typeInt) {

GrContextFactory::ContextType contextType = (GrContextFactory::ContextType) typeInt;

ContextInfo ctxInfo = factory->getContextInfo(contextType);

- if (!(*contextTypeFilter)(contextType)) {

+ if (contextTypeFilter && !(*contextTypeFilter)(contextType)) {

continue;

}

// Use "native" instead of explicitly trying OpenGL and OpenGL ES. Do not use GLES on,

« no previous file with comments | « no previous file | tests/GpuColorFilterTest.cpp » ('j') | no next file with comments »