Vulkan config in dm

Vulkan config in dm

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1872283003

Committed: https://skia.googlesource.com/skia/+/dc0fcd41e75682a8bfd5e285d684461475226330

[bsalomon, 2016-04-11 13:02:29]

Description was changed from

==========
vk config in dm

BUG=skia:
==========

to

==========
vk config in dm

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-04-11 19:23:48]

Description was changed from

==========
vk config in dm

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Vulkan config in dm

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-04-11 19:23:48]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com

[egdaniel, 2016-04-11 20:10:02]

https://codereview.chromium.org/1872283003/diff/100001/tests/VkClearTests.cpp
File tests/VkClearTests.cpp (right):

https://codereview.chromium.org/1872283003/diff/100001/tests/VkClearTests.cpp...
tests/VkClearTests.cpp:200: GrContextOptions opts;
delete opts here

https://codereview.chromium.org/1872283003/diff/100001/tools/gpu/GrContextFac...
File tools/gpu/GrContextFactory.cpp (right):

https://codereview.chromium.org/1872283003/diff/100001/tools/gpu/GrContextFac...
tools/gpu/GrContextFactory.cpp:109: SkAutoTUnref<const GrGLInterface>
glInterface;
can the glInterface be a sk_sp as well here?

https://codereview.chromium.org/1872283003/diff/100001/tools/gpu/GrContextFac...
tools/gpu/GrContextFactory.cpp:122: #   ifdef SK_BUILD_FOR_WIN
are indented ifdefs a skia style?

https://codereview.chromium.org/1872283003/diff/100001/tools/gpu/GrContextFac...
File tools/gpu/GrContextFactory.h (right):

https://codereview.chromium.org/1872283003/diff/100001/tools/gpu/GrContextFac...
tools/gpu/GrContextFactory.h:143: SkAutoTDelete<GLTestContext>   
fSentinelGLContext;
is it worth having a comment in the header for this sentinel or is the comment
in the cpp sufficient?

[bsalomon, 2016-04-11 20:40:26]

https://codereview.chromium.org/1872283003/diff/100001/tests/VkClearTests.cpp
File tests/VkClearTests.cpp (right):

https://codereview.chromium.org/1872283003/diff/100001/tests/VkClearTests.cpp...
tests/VkClearTests.cpp:200: GrContextOptions opts;
On 2016/04/11 20:10:01, egdaniel wrote:
> delete opts here

Done.

https://codereview.chromium.org/1872283003/diff/100001/tools/gpu/GrContextFac...
File tools/gpu/GrContextFactory.cpp (right):

https://codereview.chromium.org/1872283003/diff/100001/tools/gpu/GrContextFac...
tools/gpu/GrContextFactory.cpp:109: SkAutoTUnref<const GrGLInterface>
glInterface;
On 2016/04/11 20:10:01, egdaniel wrote:
> can the glInterface be a sk_sp as well here?

Done.

https://codereview.chromium.org/1872283003/diff/100001/tools/gpu/GrContextFac...
tools/gpu/GrContextFactory.cpp:122: #   ifdef SK_BUILD_FOR_WIN
On 2016/04/11 20:10:01, egdaniel wrote:
> are indented ifdefs a skia style?

there are many skia styles for nested preprocessor conditionals and this is one
of them.

https://codereview.chromium.org/1872283003/diff/100001/tools/gpu/GrContextFac...
File tools/gpu/GrContextFactory.h (right):

https://codereview.chromium.org/1872283003/diff/100001/tools/gpu/GrContextFac...
tools/gpu/GrContextFactory.h:143: SkAutoTDelete<GLTestContext>   
fSentinelGLContext;
On 2016/04/11 20:10:01, egdaniel wrote:
> is it worth having a comment in the header for this sentinel or is the comment
> in the cpp sufficient? 

I think the one in the cpp is enough.

[bsalomon, 2016-04-11 20:40:37]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-11 20:40:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1872283003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1872283003/140001

[commit-bot: I haz the power, 2016-04-11 20:42:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-11 20:42:19]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[egdaniel, 2016-04-11 20:46:48]

lgtm

[egdaniel, 2016-04-11 20:52:25]

https://codereview.chromium.org/1872283003/diff/140001/dm/DMGpuSupport.h
File dm/DMGpuSupport.h (right):

https://codereview.chromium.org/1872283003/diff/140001/dm/DMGpuSupport.h#newc...
dm/DMGpuSupport.h:83: kNullGL_ContextType        = 0;
; -> ,

[bsalomon, 2016-04-11 21:06:06]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-04-11 21:07:04]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-04-11 21:07:05]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1872283003/#ps160001
(title: "Fix no-gpu build")

[commit-bot: I haz the power, 2016-04-11 21:07:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1872283003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1872283003/160001

[commit-bot: I haz the power, 2016-04-11 21:21:36]

Description was changed from

==========
Vulkan config in dm

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Vulkan config in dm

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/dc0fcd41e75682a8bfd5e285d684461475226330
==========

[commit-bot: I haz the power, 2016-04-11 21:21:37]

Committed patchset #9 (id:160001) as
https://skia.googlesource.com/skia/+/dc0fcd41e75682a8bfd5e285d684461475226330