Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1873113002: Revert of Use GCC for snapshot_toolchain when is_clang=false. (Closed)

Created:
4 years, 8 months ago by Michael Hablich
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Use GCC for snapshot_toolchain when is_clang=false. (patchset #1 id:1 of https://codereview.chromium.org/1809643003/ ) Reason for revert: Blocks roll: https://codereview.chromium.org/1874173002/ Original issue's description: > Use GCC for snapshot_toolchain when is_clang=false. > > Currently, snapshot_toolchain is hardcoded to use a clang host > toolchain. Use a GCC toolchain if is_clang is false. > > Revert this when this is root-caused (see crbug.com/601486) > > LOG=Y > BUG=601486 > > Committed: https://crrev.com/920370d1a910681bf464bd91aced316058ea2f6c > Cr-Commit-Position: refs/heads/master@{#35341} TBR=jochen@chromium.org,alokp@chromium.org,dpranke@chromium.org,slan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=601486 LOG=Y Committed: https://crrev.com/87e7cd7f3f26d4778a5fb22d296ba12042dc6d61 Cr-Commit-Position: refs/heads/master@{#35372}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M snapshot_toolchain.gni View 1 chunk +2 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Michael Hablich
Created Revert of Use GCC for snapshot_toolchain when is_clang=false.
4 years, 8 months ago (2016-04-11 07:26:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873113002/1
4 years, 8 months ago (2016-04-11 07:26:51 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/13429)
4 years, 8 months ago (2016-04-11 07:30:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873113002/1
4 years, 8 months ago (2016-04-11 07:31:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-11 08:28:16 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 08:30:33 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87e7cd7f3f26d4778a5fb22d296ba12042dc6d61
Cr-Commit-Position: refs/heads/master@{#35372}

Powered by Google App Engine
This is Rietveld 408576698