Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1204)

Side by Side Diff: snapshot_toolchain.gni

Issue 1873113002: Revert of Use GCC for snapshot_toolchain when is_clang=false. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 the V8 project authors. All rights reserved. 1 # Copyright 2015 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 15 matching lines...) Expand all
26 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 # The snapshot needs to be compiled for the host, but compiled with 28 # The snapshot needs to be compiled for the host, but compiled with
29 # a toolchain that matches the bit-width of the target. 29 # a toolchain that matches the bit-width of the target.
30 30
31 # TODO(GYP): For now we only support 32-bit little-endian target builds from an 31 # TODO(GYP): For now we only support 32-bit little-endian target builds from an
32 # x64 Linux host. Eventually we need to support all of the host/target 32 # x64 Linux host. Eventually we need to support all of the host/target
33 # configurations v8 runs on. 33 # configurations v8 runs on.
34 if (host_cpu == "x64" && host_os == "linux") { 34 if (host_cpu == "x64" && host_os == "linux") {
35 if (target_cpu == "arm" || target_cpu == "mipsel" || target_cpu == "x86") { 35 if (target_cpu == "arm" || target_cpu == "mipsel" || target_cpu == "x86") {
36 if (is_clang) { 36 snapshot_toolchain = "//build/toolchain/linux:clang_x86"
37 snapshot_toolchain = "//build/toolchain/linux:clang_x86"
38 } else {
39 snapshot_toolchain = "//build/toolchain/linux:x86"
40 }
41 } else if (target_cpu == "x64" || target_cpu == "arm64" || target_cpu == "mips 64el") { 37 } else if (target_cpu == "x64" || target_cpu == "arm64" || target_cpu == "mips 64el") {
42 if (is_clang) { 38 snapshot_toolchain = "//build/toolchain/linux:clang_x64"
43 snapshot_toolchain = "//build/toolchain/linux:clang_x64"
44 } else {
45 snapshot_toolchain = "//build/toolchain/linux:x64"
46 }
47 } else { 39 } else {
48 assert(false, "Need environment for this arch: $target_cpu") 40 assert(false, "Need environment for this arch: $target_cpu")
49 } 41 }
50 } else { 42 } else {
51 snapshot_toolchain = default_toolchain 43 snapshot_toolchain = default_toolchain
52 } 44 }
53 45
54 46
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698