Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: snapshot_toolchain.gni

Issue 1873113002: Revert of Use GCC for snapshot_toolchain when is_clang=false. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot_toolchain.gni
diff --git a/snapshot_toolchain.gni b/snapshot_toolchain.gni
index 4d305a9b2dcd19b8aa29bedc2bd51596556cd0c0..4932110489dd1a7fe65a6124aa655192661d3bd6 100644
--- a/snapshot_toolchain.gni
+++ b/snapshot_toolchain.gni
@@ -33,17 +33,9 @@
# configurations v8 runs on.
if (host_cpu == "x64" && host_os == "linux") {
if (target_cpu == "arm" || target_cpu == "mipsel" || target_cpu == "x86") {
- if (is_clang) {
- snapshot_toolchain = "//build/toolchain/linux:clang_x86"
- } else {
- snapshot_toolchain = "//build/toolchain/linux:x86"
- }
+ snapshot_toolchain = "//build/toolchain/linux:clang_x86"
} else if (target_cpu == "x64" || target_cpu == "arm64" || target_cpu == "mips64el") {
- if (is_clang) {
- snapshot_toolchain = "//build/toolchain/linux:clang_x64"
- } else {
- snapshot_toolchain = "//build/toolchain/linux:x64"
- }
+ snapshot_toolchain = "//build/toolchain/linux:clang_x64"
} else {
assert(false, "Need environment for this arch: $target_cpu")
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698