third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js - Issue 1872673002: DevTools: introduce the bypass service worker checkbox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

Issue 1872673002: DevTools: introduce the bypass service worker checkbox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_controllee_request_handler.cc ('K') | « content/browser/service_worker/service_worker_controllee_request_handler.cc ('k') | third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js b/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

index 89806df53dda0d658c61230ddf3096e5c4aefc43..7f878ec51fa20c11bb7965025ecb8b050f449d7b 100644

--- a/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

+++ b/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js

@@ -43,10 +43,12 @@ WebInspector.ServiceWorkersView.prototype = {

this._target = target;

this._manager = this._target.serviceWorkerManager;

- var forceUpdate = new WebInspector.ToolbarCheckbox(WebInspector.UIString("Update on reload"), WebInspector.UIString("Update Service Worker on page reload"), this._manager.forceUpdateOnReloadSetting());

+ var forceUpdate = new WebInspector.ToolbarCheckbox(WebInspector.UIString("Update worker on reload"), WebInspector.UIString("Update Service Worker on page reload"), this._manager.forceUpdateOnReloadSetting());

this._toolbar.appendToolbarItem(forceUpdate);

- this._showAllCheckbox = new WebInspector.ToolbarCheckbox(WebInspector.UIString("Show all"), WebInspector.UIString("Show all Service Workers"));

+ var fallbackToNetwork = new WebInspector.ToolbarCheckbox(WebInspector.UIString("Bypass worker for network"), WebInspector.UIString("Bypass Service Worker and load resources from the network"), this._manager.fallbackToNetworkSetting());

+ this._toolbar.appendToolbarItem(fallbackToNetwork);

+ this._toolbar.appendSpacer();

+ this._showAllCheckbox = new WebInspector.ToolbarCheckbox(WebInspector.UIString("Show all"), WebInspector.UIString("Show all Service Workers regardless of the scope"));

this._showAllCheckbox.inputElement.addEventListener("change", this._onShowAllCheckboxChanged.bind(this), false);

this._toolbar.appendToolbarItem(this._showAllCheckbox);