Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js

Issue 1872673002: DevTools: introduce the bypass service worker checkbox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js
index a8a719c85953ca9ad7d367a989476bb8bb033420..b2465fed97a20e2c418daad1126e14dae7b3fdc5 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js
@@ -44,10 +44,16 @@ WebInspector.ServiceWorkerManager = function(target)
/** @type {!Map.<string, !WebInspector.ServiceWorkerRegistration>} */
this._registrations = new Map();
this.enable();
+
this._forceUpdateSetting = WebInspector.settings.createSetting("serviceWorkerUpdateOnReload", false);
if (this._forceUpdateSetting.get())
this._forceUpdateSettingChanged();
this._forceUpdateSetting.addChangeListener(this._forceUpdateSettingChanged, this);
+
+ this._fallbackToNetworkSetting = WebInspector.settings.createSetting("serviceWorkerFallbackToNetwork", false);
+ if (this._fallbackToNetworkSetting.get())
+ this._fallbackToNetworkSettingChanged();
+ this._fallbackToNetworkSetting.addChangeListener(this._fallbackToNetworkSettingChanged, this);
}
WebInspector.ServiceWorkerManager.Events = {
@@ -339,9 +345,22 @@ WebInspector.ServiceWorkerManager.prototype = {
return this._forceUpdateSetting;
},
+ /**
+ * @return {!WebInspector.Setting}
+ */
+ fallbackToNetworkSetting: function()
+ {
+ return this._fallbackToNetworkSetting;
+ },
+
_forceUpdateSettingChanged: function()
{
- this._agent.setForceUpdateOnPageLoad(this._forceUpdateSetting.get());
+ this._agent.setUpdateOnPageLoad(this._forceUpdateSetting.get());
+ },
+
+ _fallbackToNetworkSettingChanged: function()
+ {
+ this._agent.setFallbackToNetwork(this._fallbackToNetworkSetting.get());
},
__proto__: WebInspector.SDKObject.prototype

Powered by Google App Engine
This is Rietveld 408576698