content/browser/service_worker/service_worker_controllee_request_handler.cc - Issue 1872673002: DevTools: introduce the bypass service worker checkbox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_controllee_request_handler.cc

Issue 1872673002: DevTools: introduce the bypass service worker checkbox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_context_wrapper.cc ('k') | third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_controllee_request_handler.cc

diff --git a/content/browser/service_worker/service_worker_controllee_request_handler.cc b/content/browser/service_worker/service_worker_controllee_request_handler.cc

index 88cc1b9191f6f2edd105785d008182af4eda5c70..031b3d8af5bf1d0e55677dcbfad26829b7758f57 100644

--- a/content/browser/service_worker/service_worker_controllee_request_handler.cc

+++ b/content/browser/service_worker/service_worker_controllee_request_handler.cc

@@ -107,6 +107,9 @@ net::URLRequestJob* ServiceWorkerControlleeRequestHandler::MaybeCreateJob(

ServiceWorkerFetchType::FETCH, this));

job_ = job->GetWeakPtr();

+ if (context_->fallback_to_network_for_devtools())

horo 2016/04/08 05:41:15 (1) Remove line 110-112.

+ job_->FallbackToNetwork();

resource_context_ = resource_context;

if (is_main_resource_load_)

@@ -182,7 +185,7 @@ ServiceWorkerControlleeRequestHandler::DidLookupRegistrationForMainResource(

return;

const bool need_to_update = !force_update_started_ && registration &&

- context_->force_update_on_page_load();

+ context_->update_on_page_load_for_devtools();

if (provider_host_ && !need_to_update)

provider_host_->SetAllowAssociation(true);