Issue 187223002: Always round up to the next full frame when sizing WebAudio decodes.

Issue 187223002: Always round up to the next full frame when sizing WebAudio decodes. (Closed)

Created:
6 years, 9 months ago by DaleCurtis

Modified:
6 years, 9 months ago

Reviewers:
Raymond Toy (Google), Raymond Toy

CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Always round up to the next full frame when sizing WebAudio decodes. Also fixes a couple of the unittests and adds a debug log for when this occurs. BUG=176862 TEST=WebAudio reports the correct number of frames. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255162

Patch Set 1 : Rietveld!!! #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -40 lines)			Patch
M	content/renderer/media/audio_decoder.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/filters/audio_file_reader.h	View	2 chunks	+8 lines, -7 lines	0 comments	Download
M	media/filters/audio_file_reader.cc	View	4 chunks	+20 lines, -16 lines	2 comments	Download
M	media/filters/audio_file_reader_unittest.cc	View	5 chunks	+17 lines, -16 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Raymond Toy (Google)

lgtm, with a nit. https://codereview.chromium.org/187223002/diff/20001/media/filters/audio_file_reader.cc File media/filters/audio_file_reader.cc (right): https://codereview.chromium.org/187223002/diff/20001/media/filters/audio_file_reader.cc#newcode234 media/filters/audio_file_reader.cc:234: base::TimeDelta AudioFileReader::GetDuration() const { Why ...

6 years, 9 months ago (2014-03-05 18:28:00 UTC) #2

DaleCurtis

Thanks for the review! https://codereview.chromium.org/187223002/diff/20001/media/filters/audio_file_reader.cc File media/filters/audio_file_reader.cc (right): https://codereview.chromium.org/187223002/diff/20001/media/filters/audio_file_reader.cc#newcode234 media/filters/audio_file_reader.cc:234: base::TimeDelta AudioFileReader::GetDuration() const { On ...

6 years, 9 months ago (2014-03-05 19:27:35 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/187223002/20001

6 years, 9 months ago (2014-03-05 19:28:43 UTC) #5

Hajime Morrita

Hi, this might be breaking some layout tests. Could you take a look? http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=webaudio/codec-tests/vorbis/vbr-128kbps-44khz.html,webaudio/codec-tests/vorbis/vbr-70kbps-44khz.html,webaudio/codec-tests/vorbis/vbr-96kbps-44khz.html

6 years, 9 months ago (2014-03-05 23:54:16 UTC) #7

DaleCurtis

On 2014/03/05 23:54:16, morrita1 wrote: > Hi, this might be breaking some layout tests. > ...

6 years, 9 months ago (2014-03-05 23:58:01 UTC) #8

Hajime Morrita

6 years, 9 months ago (2014-03-05 23:59:32 UTC) #9

Message was sent while issue was closed.

On 2014/03/05 23:58:01, DaleCurtis wrote:
> On 2014/03/05 23:54:16, morrita1 wrote:
> > Hi, this might be breaking some layout tests.
> > Could you take a look?
> > 
> >
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%25...
> 
> Sure, they just need to be rebaselined since previously they were getting
> clipped.

Ah I see. I'll add NeedsRebaseline. Thanks!

Expand Messages | Collapse Messages