Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: media/filters/audio_file_reader.h

Issue 187223002: Always round up to the next full frame when sizing WebAudio decodes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rietveld!!! Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/audio_file_reader.h
diff --git a/media/filters/audio_file_reader.h b/media/filters/audio_file_reader.h
index e345dc05808f0ea9051414d71595efb79b2766bf..8a4ed276832388ae0462fbcde6aaa9f464fa82ba 100644
--- a/media/filters/audio_file_reader.h
+++ b/media/filters/audio_file_reader.h
@@ -28,7 +28,7 @@ class MEDIA_EXPORT AudioFileReader {
virtual ~AudioFileReader();
// Open() reads the audio data format so that the sample_rate(),
- // channels(), duration(), and number_of_frames() methods can be called.
+ // channels(), GetDuration(), and GetNumberOfFrames() methods can be called.
// It returns |true| on success.
bool Open();
void Close();
@@ -46,12 +46,13 @@ class MEDIA_EXPORT AudioFileReader {
int channels() const { return channels_; }
int sample_rate() const { return sample_rate_; }
- // Please note that duration() and number_of_frames() attempt to be accurate,
- // but are only estimates. For some encoded formats, the actual duration
- // of the file can only be determined once all the file data has been read.
- // The Read() method returns the actual number of sample-frames it has read.
- base::TimeDelta duration() const;
- int64 number_of_frames() const;
+ // Please note that GetDuration() and GetNumberOfFrames() attempt to be
+ // accurate, but are only estimates. For some encoded formats, the actual
+ // duration of the file can only be determined once all the file data has been
+ // read. The Read() method returns the actual number of sample-frames it has
+ // read.
+ base::TimeDelta GetDuration() const;
+ int GetNumberOfFrames() const;
private:
scoped_ptr<FFmpegGlue> glue_;

Powered by Google App Engine
This is Rietveld 408576698