Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Unified Diff: media/filters/audio_file_reader_unittest.cc

Issue 187223002: Always round up to the next full frame when sizing WebAudio decodes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rietveld!!! Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/filters/audio_file_reader.cc ('K') | « media/filters/audio_file_reader.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/audio_file_reader_unittest.cc
diff --git a/media/filters/audio_file_reader_unittest.cc b/media/filters/audio_file_reader_unittest.cc
index a50c8c2a75e719337ccee8d3fd5a7008b6c46861..28c9837cb2e189d48629c3f0d5fec9adca0af999 100644
--- a/media/filters/audio_file_reader_unittest.cc
+++ b/media/filters/audio_file_reader_unittest.cc
@@ -30,7 +30,7 @@ class AudioFileReaderTest : public testing::Test {
// Reads and the entire file provided to Initialize().
void ReadAndVerify(const char* expected_audio_hash, int expected_frames) {
scoped_ptr<AudioBus> decoded_audio_data = AudioBus::Create(
- reader_->channels(), reader_->number_of_frames());
+ reader_->channels(), reader_->GetNumberOfFrames());
int actual_frames = reader_->Read(decoded_audio_data.get());
ASSERT_LE(actual_frames, decoded_audio_data->frames());
ASSERT_EQ(expected_frames, actual_frames);
@@ -46,8 +46,9 @@ class AudioFileReaderTest : public testing::Test {
ASSERT_TRUE(reader_->Open());
EXPECT_EQ(channels, reader_->channels());
EXPECT_EQ(sample_rate, reader_->sample_rate());
- EXPECT_EQ(duration.InMicroseconds(), reader_->duration().InMicroseconds());
- EXPECT_EQ(frames, reader_->number_of_frames());
+ EXPECT_EQ(duration.InMicroseconds(),
+ reader_->GetDuration().InMicroseconds());
+ EXPECT_EQ(frames, reader_->GetNumberOfFrames());
ReadAndVerify(hash, trimmed_frames);
}
@@ -60,7 +61,7 @@ class AudioFileReaderTest : public testing::Test {
Initialize(fn);
EXPECT_TRUE(reader_->Open());
scoped_ptr<AudioBus> decoded_audio_data = AudioBus::Create(
- reader_->channels(), reader_->number_of_frames());
+ reader_->channels(), reader_->GetNumberOfFrames());
EXPECT_EQ(reader_->Read(decoded_audio_data.get()), 0);
}
@@ -81,49 +82,49 @@ TEST_F(AudioFileReaderTest, InvalidFile) {
}
TEST_F(AudioFileReaderTest, WithVideo) {
- RunTest("bear.ogv", "-2.49,-0.75,0.38,1.60,-0.15,-1.22,", 2, 44100,
- base::TimeDelta::FromMicroseconds(1011520), 44608, 44608);
+ RunTest("bear.ogv", "-2.49,-0.75,0.38,1.60,0.70,-1.22,", 2, 44100,
+ base::TimeDelta::FromMicroseconds(1011520), 44609, 44609);
}
TEST_F(AudioFileReaderTest, Vorbis) {
- RunTest("sfx.ogg", "4.36,4.81,4.84,4.34,4.61,4.63,", 1, 44100,
- base::TimeDelta::FromMicroseconds(350001), 15435, 15435);
+ RunTest("sfx.ogg", "4.36,4.81,4.84,4.45,4.61,4.63,", 1, 44100,
+ base::TimeDelta::FromMicroseconds(350001), 15436, 15436);
}
TEST_F(AudioFileReaderTest, WaveU8) {
RunTest("sfx_u8.wav", "-1.23,-1.57,-1.14,-0.91,-0.87,-0.07,", 1, 44100,
- base::TimeDelta::FromMicroseconds(288414), 12719, 12719);
+ base::TimeDelta::FromMicroseconds(288414), 12720, 12719);
}
TEST_F(AudioFileReaderTest, WaveS16LE) {
RunTest("sfx_s16le.wav", "3.05,2.87,3.00,3.32,3.58,4.08,", 1, 44100,
- base::TimeDelta::FromMicroseconds(288414), 12719, 12719);
+ base::TimeDelta::FromMicroseconds(288414), 12720, 12719);
}
TEST_F(AudioFileReaderTest, WaveS24LE) {
RunTest("sfx_s24le.wav", "3.03,2.86,2.99,3.31,3.57,4.06,", 1, 44100,
- base::TimeDelta::FromMicroseconds(288414), 12719, 12719);
+ base::TimeDelta::FromMicroseconds(288414), 12720, 12719);
}
TEST_F(AudioFileReaderTest, WaveF32LE) {
RunTest("sfx_f32le.wav", "3.03,2.86,2.99,3.31,3.57,4.06,", 1, 44100,
- base::TimeDelta::FromMicroseconds(288414), 12719, 12719);
+ base::TimeDelta::FromMicroseconds(288414), 12720, 12719);
}
#if defined(USE_PROPRIETARY_CODECS)
TEST_F(AudioFileReaderTest, MP3) {
RunTest("sfx.mp3", "3.05,2.87,3.00,3.32,3.58,4.08,", 1, 44100,
- base::TimeDelta::FromMicroseconds(313470), 13824, 12719);
+ base::TimeDelta::FromMicroseconds(313470), 13825, 12719);
}
TEST_F(AudioFileReaderTest, CorruptMP3) {
RunTest("corrupt.mp3", "-4.95,-2.95,-0.44,1.16,0.31,-2.21,", 1, 44100,
- base::TimeDelta::FromMicroseconds(1018826), 44930, 44928);
+ base::TimeDelta::FromMicroseconds(1018826), 44931, 44928);
}
TEST_F(AudioFileReaderTest, AAC) {
RunTest("sfx.m4a", "1.81,1.66,2.32,3.27,4.46,3.36,", 1, 44100,
- base::TimeDelta::FromMicroseconds(312001), 13759, 13312);
+ base::TimeDelta::FromMicroseconds(312001), 13760, 13312);
}
TEST_F(AudioFileReaderTest, MidStreamConfigChangesFail) {
@@ -137,7 +138,7 @@ TEST_F(AudioFileReaderTest, VorbisInvalidChannelLayout) {
TEST_F(AudioFileReaderTest, WaveValidFourChannelLayout) {
RunTest("4ch.wav", "131.71,38.02,130.31,44.89,135.98,42.52,", 4, 44100,
- base::TimeDelta::FromMicroseconds(100001), 4410, 4410);
+ base::TimeDelta::FromMicroseconds(100001), 4411, 4410);
}
} // namespace media
« media/filters/audio_file_reader.cc ('K') | « media/filters/audio_file_reader.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698