Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1872203005: Fix printf formats (Closed)

Created:
4 years, 8 months ago by JF
Modified:
4 years, 8 months ago
CC:
Hannes Payer (out of office), Michael Starzinger, ulan, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix printf formats The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL: - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h. - Uses it appropriately. - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done). - Fixes a bunch of incorrect formats. Original CL: https://codereview.chromium.org/1869433004 Reverted in: https://codereview.chromium.org/1867383002 Reverted again in: https://codereview.chromium.org/1877823003 Reverts due to non-CQ bots: - First: v8_win_dbg, v8_win64_dbg, v8_mac_dbg - Second: gc mole (added to v8_linux_rel_ng for this patch) R= jochen@chromium.org TBR= ahaas@chromium.org,bmeurer@chromium.org,yangguo@chromium.org Committed: https://crrev.com/90418336477d3ed94c610b65ace310db0ef51f64 Cr-Commit-Position: refs/heads/master@{#35423}

Patch Set 1 #

Patch Set 2 : Fix unused param found by GC mole #

Unified diffs Side-by-side diffs Delta from patch set Stats (+355 lines, -264 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/simulator-arm64.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/ast/prettyprinter.h View 3 chunks +3 lines, -2 lines 0 comments Download
M src/ast/prettyprinter.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M src/base/compiler-specific.h View 1 chunk +11 lines, -0 lines 0 comments Download
A src/base/format-macros.h View 1 chunk +97 lines, -0 lines 0 comments Download
M src/base/logging.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/base/macros.h View 2 chunks +14 lines, -15 lines 0 comments Download
M src/base/platform/platform.h View 3 chunks +12 lines, -11 lines 0 comments Download
M src/compilation-statistics.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/crankshaft/hydrogen-range-analysis.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/crankshaft/lithium-allocator.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/crankshaft/lithium-codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/disassembler.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M src/global-handles.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/heap/gc-idle-time-handler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/heap/gc-tracer.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/heap/gc-tracer.cc View 3 chunks +29 lines, -29 lines 0 comments Download
M src/heap/heap.cc View 6 chunks +47 lines, -49 lines 0 comments Download
M src/heap/mark-compact.cc View 2 chunks +11 lines, -12 lines 0 comments Download
M src/heap/spaces.cc View 5 chunks +6 lines, -14 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/log.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/log.cc View 9 chunks +12 lines, -14 lines 0 comments Download
M src/log-utils.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/log-utils.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/profiler/allocation-tracker.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/profiler/profile-generator.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M src/profiler/strings-storage.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/snapshot/serializer.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/utils.h View 3 chunks +11 lines, -30 lines 0 comments Download
M src/wasm/decoder.h View 4 chunks +8 lines, -5 lines 0 comments Download
M src/wasm/wasm-result.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/x64/disasm-x64.cc View 1 6 chunks +10 lines, -9 lines 0 comments Download
M src/x87/disasm-x87.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +10 lines, -6 lines 0 comments Download
M test/cctest/test-log.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872203005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872203005/20001
4 years, 8 months ago (2016-04-11 19:59:02 UTC) #3
JF
Trying again. Is there a way to run the gc mole bot? I can't find ...
4 years, 8 months ago (2016-04-11 19:59:59 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-11 20:52:02 UTC) #6
Michael Achenbach
Nope, not yet. Please file me a bug if it becomes urgent. CC'ing mstarzinger for ...
4 years, 8 months ago (2016-04-12 08:19:37 UTC) #8
Michael Achenbach
On 2016/04/12 08:19:37, Michael Achenbach wrote: > Nope, not yet. Please file me a bug ...
4 years, 8 months ago (2016-04-12 09:33:55 UTC) #9
Michael Achenbach
FYI: I added gcmole to the v8_linux_rel_ng bot and retriggered the bot: https://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng_triggered/builds/3817 Seems to ...
4 years, 8 months ago (2016-04-12 11:55:56 UTC) #10
JF
OK ty. Can I get an lgtm on this?
4 years, 8 months ago (2016-04-12 15:35:55 UTC) #12
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-12 15:39:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872203005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872203005/20001
4 years, 8 months ago (2016-04-12 15:48:39 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-12 16:13:16 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 16:14:09 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/90418336477d3ed94c610b65ace310db0ef51f64
Cr-Commit-Position: refs/heads/master@{#35423}

Powered by Google App Engine
This is Rietveld 408576698