[SyncFS] Improve debug logs of MetadataDatabaseIndex

[SyncFS] Insert DVLOGs to for debugging

 * Insert DVLOGs for debugging
 * Drop unused parameter for demoted dirty tracker.
 * Add FileTracker accessor by parent tracker
 * Handle title change on MetadataDatabaseIndex


BUG=344769
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255012

[tzik, 2014-03-05 03:33:48]

PTL

[nhiroki, 2014-03-05 04:13:38]

Looks good overall.

https://codereview.chromium.org/187203004/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc
(right):

https://codereview.chromium.org/187203004/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc:127:
DVLOG(3) << "Removing tracker: " << tracker->tracker_id();
nit: can you print tracker's title?

https://codereview.chromium.org/187203004/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc:220:
DVLOG(3) << "  Add to app_root_by_app_id_: " << new_tracker.app_id();
just curious: why do you prepend whitespaces? for grouping logs??

https://codereview.chromium.org/187203004/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc:406: <<
"  Remove From multi_backing_file_paths_: "
nit: s/From/from

https://codereview.chromium.org/187203004/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc:450:
demoted_dirty_trackers_.erase(tracker_id);
You've already checked that |demoted_dirty_trackers_| does not have |tracker_id|
at line 445.

[tzik, 2014-03-05 05:18:40]

https://codereview.chromium.org/187203004/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc
(right):

https://codereview.chromium.org/187203004/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc:127:
DVLOG(3) << "Removing tracker: " << tracker->tracker_id();
On 2014/03/05 04:13:38, nhiroki wrote:
> nit: can you print tracker's title?

Done.

https://codereview.chromium.org/187203004/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc:220:
DVLOG(3) << "  Add to app_root_by_app_id_: " << new_tracker.app_id();
On 2014/03/05 04:13:38, nhiroki wrote:
> just curious: why do you prepend whitespaces? for grouping logs??

Yes, it's just for making the log readable.

https://codereview.chromium.org/187203004/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc:406: <<
"  Remove From multi_backing_file_paths_: "
On 2014/03/05 04:13:38, nhiroki wrote:
> nit: s/From/from

Done.

https://codereview.chromium.org/187203004/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc:450:
demoted_dirty_trackers_.erase(tracker_id);
On 2014/03/05 04:13:38, nhiroki wrote:
> You've already checked that |demoted_dirty_trackers_| does not have
|tracker_id|
> at line 445.

Ah, that's true. Removed.

[nhiroki, 2014-03-05 05:22:23]

lgtm

[tzik, 2014-03-05 05:26:49]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-03-05 05:29:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/187203004/20001

[commit-bot: I haz the power, 2014-03-05 07:56:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-05 07:56:36]

Retried try job too often on win_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[tzik, 2014-03-05 08:23:22]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-03-05 08:23:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/187203004/20001

[commit-bot: I haz the power, 2014-03-05 11:34:00]

Change committed as 255012