[SyncFS] Improve debug logs of MetadataDatabaseIndex

chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <stack>
 
 #include "base/file_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
@@ skipping 327 matching lines @@
                                   const std::string& folder_id,
                                   CannedSyncableFileSystem* file_system) {
     SCOPED_TRACE(testing::Message() << "Verifying folder: " << path.value());
 
     ScopedVector<google_apis::ResourceEntry> remote_entries;
     EXPECT_EQ(google_apis::HTTP_SUCCESS,
               fake_drive_service_helper_->ListFilesInFolder(
                   folder_id, &remote_entries));
     std::map<std::string, const google_apis::ResourceEntry*>
         remote_entry_by_title;
-    for (ScopedVector<google_apis::ResourceEntry>::iterator itr =
-             remote_entries.begin();
-         itr != remote_entries.end();
-         ++itr) {
-      const google_apis::ResourceEntry& remote_entry = **itr;
-      EXPECT_FALSE(ContainsKey(remote_entry_by_title, remote_entry.title()));
-      remote_entry_by_title[remote_entry.title()] = *itr;
+    for (size_t i = 0; i < remote_entries.size(); ++i) {
+      google_apis::ResourceEntry* remote_entry = remote_entries[i];
+      EXPECT_FALSE(ContainsKey(remote_entry_by_title, remote_entry->title()))
+          << "title: " << remote_entry->title();
+      remote_entry_by_title[remote_entry->title()] = remote_entry;
     }
 
     fileapi::FileSystemURL url(CreateURL(app_id, path));
     FileEntryList local_entries;
     EXPECT_EQ(base::File::FILE_OK,
               file_system->ReadDirectory(url, &local_entries));
     for (FileEntryList::iterator itr = local_entries.begin();
          itr != local_entries.end();
          ++itr) {
       const fileapi::DirectoryEntry& local_entry = *itr;
@@ skipping 1216 matching lines @@
 
   EXPECT_EQ(1u, CountApp());
   EXPECT_EQ(1u, CountLocalFile(app_id));
 
   EXPECT_EQ(2u, CountMetadata());
   EXPECT_EQ(2u, CountTracker());
 }
 
 }  // namespace drive_backend
 }  // namespace sync_file_system