Add parsing for ambient declarations

Add parsing for ambient declarations

Allowing on purpose:
-   binding patterns in ambient variable declarations,
-   anonymous functions in export default declare.

This is based on https://codereview.chromium.org/1853763002
but the patch is actually taken from a version merged with
upstream master.

R=rossberg@chromium.org
BUG=
NOTRY=true
NOPRESUBMIT=true

[rossberg, 2016-04-20 15:16:35]

It's a bit unfortunate that you have to pass the ambient flag everywhere, but I
have no better idea. I think you can get rid of the toplevel flag, though, see
below.

https://codereview.chromium.org/1871923003/diff/1/src/parsing/parser.h
File src/parsing/parser.h (right):

https://codereview.chromium.org/1871923003/diff/1/src/parsing/parser.h#newcod...
src/parsing/parser.h:788: bool top_level, bool* ok);
Instead of this flag, couldn't you simply look at the kind of the current scope
is?

https://codereview.chromium.org/1871923003/diff/1/src/parsing/preparser.cc
File src/parsing/preparser.cc (right):

https://codereview.chromium.org/1871923003/diff/1/src/parsing/preparser.cc#ne...
src/parsing/preparser.cc:576: // Skip initializers, for ambient declarations.
Nit: maybe don't say "skip initializers", but "no initializers"?

https://codereview.chromium.org/1871923003/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/1871923003/diff/1/test/cctest/test-parsing.cc...
test/cctest/test-parsing.cc:8156: "export default declare function f()",
Sigh, this syntax is such a mess...

[nickie, 2016-04-21 13:57:10]

https://codereview.chromium.org/1871923003/diff/1/src/parsing/parser.h
File src/parsing/parser.h (right):

https://codereview.chromium.org/1871923003/diff/1/src/parsing/parser.h#newcod...
src/parsing/parser.h:788: bool top_level, bool* ok);
On 2016/04/20 15:16:34, rossberg wrote:
> Instead of this flag, couldn't you simply look at the kind of the current
scope
> is?

Depending on https://codereview.chromium.org/1906793002/, this can indeed be
done.  (When I uploaded the CL, it was not possible, because of a
parser/preparser out-of-sync.)  I'm changing it now.

https://codereview.chromium.org/1871923003/diff/1/src/parsing/preparser.cc
File src/parsing/preparser.cc (right):

https://codereview.chromium.org/1871923003/diff/1/src/parsing/preparser.cc#ne...
src/parsing/preparser.cc:576: // Skip initializers, for ambient declarations.
On 2016/04/20 15:16:35, rossberg wrote:
> Nit: maybe don't say "skip initializers", but "no initializers"?

Done.

https://codereview.chromium.org/1871923003/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/1871923003/diff/1/test/cctest/test-parsing.cc...
test/cctest/test-parsing.cc:8156: "export default declare function f()",
On 2016/04/20 15:16:35, rossberg wrote:
> Sigh, this syntax is such a mess...

Acknowledged.  :-)

[nickie, 2016-04-21 13:59:10]

https://codereview.chromium.org/1871923003/diff/20001/src/parsing/preparser.cc
File src/parsing/preparser.cc (right):

https://codereview.chromium.org/1871923003/diff/20001/src/parsing/preparser.c...
src/parsing/preparser.cc:471: Scope* block_scope = NewScope(scope_,
BLOCK_SCOPE);
The changes in this method are repeated in
https://codereview.chromium.org/1871923003/
which just landed in master.

[rossberg, 2016-04-21 14:01:36]

lgtm

[nickie, 2016-04-21 14:54:36]

Patchset 2 landed MANUALLY in experimental/nikolaos/types as:
b7677f074accfafe787f73f4a85264966b39d635
https://chromium.googlesource.com/v8/v8/+/b7677f074accfafe787f73f4a85264966b3...

[nickie, 2016-04-21 14:54:54]

Description was changed from

==========
Add parsing for ambient declarations

Allowing on purpose:
-   binding patterns in ambient variable declarations,
-   anonymous functions in export default declare.

This is based on https://codereview.chromium.org/1853763002
but the patch is actually taken from a version merged with
upstream master.

R=rossberg@chromium.org
BUG=
NOTRY=true
NOPRESUBMIT=true
==========

to

==========
Add parsing for ambient declarations

Allowing on purpose:
-   binding patterns in ambient variable declarations,
-   anonymous functions in export default declare.

This is based on https://codereview.chromium.org/1853763002
but the patch is actually taken from a version merged with
upstream master.

R=rossberg@chromium.org
BUG=
NOTRY=true
NOPRESUBMIT=true
==========