Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1853763002: Allow constructor and method signatures in classes (Closed)

Created:
4 years, 8 months ago by nickie
Modified:
4 years, 8 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@types-1849803002-intf-decl
Target Ref:
refs/pending/heads/experimental/nikolaos/types
Project:
v8
Visibility:
Public.

Description

Allow constructor and method signatures in classes This is based on https://codereview.chromium.org/1849803002 R=rossberg@chromium.org BUG= NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Patch Set 2 : Fix method type annotations in the preparser #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -9 lines) Patch
M src/ast/ast.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/parsing/parser.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/parser-base.h View 6 chunks +28 lines, -0 lines 0 comments Download
M src/parsing/preparser.h View 4 chunks +11 lines, -1 line 0 comments Download
M src/parsing/preparser.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 1 2 chunks +3 lines, -0 lines 3 comments Download
M test/mjsunit/harmony/typesystem/class-declarations.js View 3 chunks +31 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (1 generated)
nickie
4 years, 8 months ago (2016-04-01 13:36:13 UTC) #1
rossberg
LGTM modulo test https://codereview.chromium.org/1853763002/diff/20001/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/1853763002/diff/20001/test/cctest/test-parsing.cc#newcode7885 test/cctest/test-parsing.cc:7885: "class C { constructor (x: number); ...
4 years, 8 months ago (2016-04-18 11:13:10 UTC) #2
nickie
https://codereview.chromium.org/1853763002/diff/20001/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/1853763002/diff/20001/test/cctest/test-parsing.cc#newcode7885 test/cctest/test-parsing.cc:7885: "class C { constructor (x: number); constructor (x) {} ...
4 years, 8 months ago (2016-04-18 12:35:09 UTC) #3
nickie
4 years, 8 months ago (2016-04-20 14:29:47 UTC) #4
Patchset 2 landed MANUALLY in experimental/nikolaos/types as:
fa11a13e9bdd134f30454c6492f995a9311dac60
https://chromium.googlesource.com/v8/v8/+/fa11a13e9bdd134f30454c6492f995a9311...

Powered by Google App Engine
This is Rietveld 408576698