src/messages.h - Issue 1871923003: Add parsing for ambient declarations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/messages.h

Issue 1871923003: Add parsing for ambient declarations (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@types-devel

Patch Set: Minor fixes to address code review comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/messages.h

diff --git a/src/messages.h b/src/messages.h

index a5c4f677b24b14fd36333870e26d340fd29f9139..968d53081c5b642f26c1b1d5e6c5ac41c9c73ba5 100644

--- a/src/messages.h

+++ b/src/messages.h

@@ -481,6 +481,11 @@ class CallSite {

T(BadFunctionOrConstructorType, \

"Expecting '=>' in function or constructor type.") \

T(BadIndexType, "Invalid index type: expected 'number' or 'string'") \

+ T(BadAmbientDeclaration, \

+ "Invalid ambient: expected variable, function or class declaration") \

+ T(IllegalDeclare, \

+ "Unexpected 'declare', ambient declaration not allowed here") \

+ T(AmbientGetOrSet, "Unexpected 'get' or 'set' in ambient class declaration") \

/* EvalError */ \

T(CodeGenFromStrings, "%") \

/* URIError */ \