src/frames.cc - Issue 1871423002: [heap] Refactor Sweeper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/frames.cc

Issue 1871423002: [heap] Refactor Sweeper (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Comments round 2 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/frames.cc

diff --git a/src/frames.cc b/src/frames.cc

index d9fa728b07a3bcf01b18f93545ced149cea8dd65..4f2f0086a794243001b82db0f5a41bec354ebbd5 100644

--- a/src/frames.cc

+++ b/src/frames.cc

@@ -1641,7 +1641,8 @@ Code* InnerPointerToCodeCache::GcSafeFindCodeForInnerPointer(

Page* page = Page::FromAddress(inner_pointer);

DCHECK_EQ(page->owner(), heap->code_space());

- heap->mark_compact_collector()->SweepOrWaitUntilSweepingCompleted(page);

+ heap->mark_compact_collector()->sweeper().SweepOrWaitUntilSweepingCompleted(

+ page);

Address addr = page->skip_list()->StartFor(inner_pointer);

« no previous file with comments | « no previous file | src/heap/incremental-marking.cc » ('j') | no next file with comments »