Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Side by Side Diff: src/frames.cc

Issue 1871423002: [heap] Refactor Sweeper (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Comments round 2 Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/heap/incremental-marking.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/frames.h" 5 #include "src/frames.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/ast/ast.h" 9 #include "src/ast/ast.h"
10 #include "src/ast/scopeinfo.h" 10 #include "src/ast/scopeinfo.h"
(...skipping 1623 matching lines...) Expand 10 before | Expand all | Expand 10 after
1634 1634
1635 if (!heap->code_space()->Contains(inner_pointer)) { 1635 if (!heap->code_space()->Contains(inner_pointer)) {
1636 return nullptr; 1636 return nullptr;
1637 } 1637 }
1638 1638
1639 // Iterate through the page until we reach the end or find an object starting 1639 // Iterate through the page until we reach the end or find an object starting
1640 // after the inner pointer. 1640 // after the inner pointer.
1641 Page* page = Page::FromAddress(inner_pointer); 1641 Page* page = Page::FromAddress(inner_pointer);
1642 1642
1643 DCHECK_EQ(page->owner(), heap->code_space()); 1643 DCHECK_EQ(page->owner(), heap->code_space());
1644 heap->mark_compact_collector()->SweepOrWaitUntilSweepingCompleted(page); 1644 heap->mark_compact_collector()->sweeper().SweepOrWaitUntilSweepingCompleted(
1645 page);
1645 1646
1646 Address addr = page->skip_list()->StartFor(inner_pointer); 1647 Address addr = page->skip_list()->StartFor(inner_pointer);
1647 1648
1648 Address top = heap->code_space()->top(); 1649 Address top = heap->code_space()->top();
1649 Address limit = heap->code_space()->limit(); 1650 Address limit = heap->code_space()->limit();
1650 1651
1651 while (true) { 1652 while (true) {
1652 if (addr == top && addr != limit) { 1653 if (addr == top && addr != limit) {
1653 addr = limit; 1654 addr = limit;
1654 continue; 1655 continue;
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
1747 for (StackFrameIterator it(isolate); !it.done(); it.Advance()) { 1748 for (StackFrameIterator it(isolate); !it.done(); it.Advance()) {
1748 StackFrame* frame = AllocateFrameCopy(it.frame(), zone); 1749 StackFrame* frame = AllocateFrameCopy(it.frame(), zone);
1749 list.Add(frame, zone); 1750 list.Add(frame, zone);
1750 } 1751 }
1751 return list.ToVector(); 1752 return list.ToVector();
1752 } 1753 }
1753 1754
1754 1755
1755 } // namespace internal 1756 } // namespace internal
1756 } // namespace v8 1757 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/heap/incremental-marking.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698