src/heap/incremental-marking.cc - Issue 1871423002: [heap] Refactor Sweeper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/incremental-marking.cc

Issue 1871423002: [heap] Refactor Sweeper (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Comments round 2 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/incremental-marking.cc

diff --git a/src/heap/incremental-marking.cc b/src/heap/incremental-marking.cc

index cdc245cd2233aacfe2d413e6a96b3d4d5dc0845e..fe0f567d62062856bd1396e87f07c5ddd8df8dd4 100644

--- a/src/heap/incremental-marking.cc

+++ b/src/heap/incremental-marking.cc

@@ -1110,7 +1110,7 @@ void IncrementalMarking::SpeedUp() {

void IncrementalMarking::FinalizeSweeping() {

DCHECK(state_ == SWEEPING);

if (heap_->mark_compact_collector()->sweeping_in_progress() &&

- (heap_->mark_compact_collector()->IsSweepingCompleted() ||

+ (heap_->mark_compact_collector()->sweeper().IsSweepingCompleted() ||

!FLAG_concurrent_sweeping)) {

heap_->mark_compact_collector()->EnsureSweepingCompleted();

}

« no previous file with comments | « src/frames.cc ('k') | src/heap/mark-compact.h » ('j') | no next file with comments »