Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp

Issue 1871393003: Don't persist the SVGTextLayoutAttributesBuilder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: explicit Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp
index 397cfd2c67ce7a6d59042db7cc3b0cba3d8d31ab..9413c6868a932a243361ee2fae82e3477ece1982 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp
@@ -39,6 +39,7 @@
#include "core/layout/svg/LayoutSVGRoot.h"
#include "core/layout/svg/SVGLayoutSupport.h"
#include "core/layout/svg/SVGResourcesCache.h"
+#include "core/layout/svg/SVGTextLayoutAttributesBuilder.h"
#include "core/layout/svg/line/SVGRootInlineBox.h"
#include "core/paint/SVGTextPainter.h"
#include "core/style/ShadowList.h"
@@ -82,7 +83,6 @@ LayoutSVGText::~LayoutSVGText()
void LayoutSVGText::willBeDestroyed()
{
m_layoutAttributes.clear();
- m_layoutAttributesBuilder.clearTextPositioningElements();
LayoutSVGBlock::willBeDestroyed();
}
@@ -113,7 +113,6 @@ static inline void collectLayoutAttributes(LayoutObject* text, Vector<SVGTextLay
void LayoutSVGText::invalidatePositioningValues(LayoutInvalidationReasonForTracing reason)
{
m_layoutAttributes.clear();
- m_layoutAttributesBuilder.clearTextPositioningElements();
setNeedsPositioningValuesUpdate();
setNeedsLayoutAndFullPaintInvalidation(reason);
}
@@ -122,7 +121,6 @@ void LayoutSVGText::subtreeChildWasAdded()
{
if (beingDestroyed() || !everHadLayout()) {
ASSERT(m_layoutAttributes.isEmpty());
- ASSERT(!m_layoutAttributesBuilder.numberOfTextPositioningElements());
return;
}
if (documentBeingDestroyed())
@@ -138,7 +136,6 @@ void LayoutSVGText::subtreeChildWillBeRemoved()
{
if (beingDestroyed() || !everHadLayout()) {
ASSERT(m_layoutAttributes.isEmpty());
- ASSERT(!m_layoutAttributesBuilder.numberOfTextPositioningElements());
return;
}
@@ -153,7 +150,6 @@ void LayoutSVGText::subtreeTextDidChange()
ASSERT(!beingDestroyed());
if (!everHadLayout()) {
ASSERT(m_layoutAttributes.isEmpty());
- ASSERT(!m_layoutAttributesBuilder.numberOfTextPositioningElements());
return;
}
@@ -203,7 +199,8 @@ void LayoutSVGText::layout()
ASSERT(m_layoutAttributes.isEmpty());
collectLayoutAttributes(this, m_layoutAttributes);
updateFontAndMetrics(*this);
- m_layoutAttributesBuilder.buildLayoutAttributesForTextRoot(*this);
+
+ SVGTextLayoutAttributesBuilder(*this).buildLayoutAttributes();
m_needsReordering = true;
m_needsTextMetricsUpdate = false;
@@ -219,7 +216,9 @@ void LayoutSVGText::layout()
m_layoutAttributes.clear();
collectLayoutAttributes(this, m_layoutAttributes);
- m_layoutAttributesBuilder.buildLayoutAttributesForTextRoot(*this);
+
+ SVGTextLayoutAttributesBuilder(*this).buildLayoutAttributes();
+
m_needsReordering = true;
m_needsPositioningValuesUpdate = false;
updateCachedBoundariesInParents = true;

Powered by Google App Engine
This is Rietveld 408576698