chrome/android/java/res/layout/new_tab_page_snippets_card.xml - Issue 1871343006: [NTP Snippets] 📷 Add placeholders and start caching thumbnails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/new_tab_page_snippets_card.xml

Issue 1871343006: [NTP Snippets] 📷 Add placeholders and start caching thumbnails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move the async task out as it needs to be stopped from the view, not the snippet Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/res/drawable/ic_snippet_thumbnail_placeholder.xml ('K') | « chrome/android/java/res/drawable/ic_snippet_thumbnail_placeholder.xml ('k') | chrome/android/java/res/values/colors.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/ThumbnailFetchingTask.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/new_tab_page_snippets_card.xml

diff --git a/chrome/android/java/res/layout/new_tab_page_snippets_card.xml b/chrome/android/java/res/layout/new_tab_page_snippets_card.xml

index 8464c146d051ac431c60bf5471bdeae05c805285..703bfec4ec77b22c4c1ff6237020ad17d0eb6731 100644

--- a/chrome/android/java/res/layout/new_tab_page_snippets_card.xml

+++ b/chrome/android/java/res/layout/new_tab_page_snippets_card.xml

@@ -46,9 +46,10 @@

android:ellipsize="end"

android:textSize="14sp"

android:textColor="@color/snippets_publisher_name_color" />

<ImageView

android:id="@+id/article_thumbnail"

+ android:background="@color/snippets_thumnail_placeholder_bg"

android:layout_width="@dimen/snippets_thumbnail_size"

android:layout_height="@dimen/snippets_thumbnail_size"

android:layout_alignParentTop="true"