Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: chrome/android/java/res/layout/new_tab_page_snippets_card.xml

Issue 1871343006: [NTP Snippets] 📷 Add placeholders and start caching thumbnails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move the async task out as it needs to be stopped from the view, not the snippet Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <RelativeLayout 6 <RelativeLayout
7 xmlns:android="http://schemas.android.com/apk/res/android" 7 xmlns:android="http://schemas.android.com/apk/res/android"
8 android:id="@+id/snippets_card_view" 8 android:id="@+id/snippets_card_view"
9 android:layout_width="match_parent" 9 android:layout_width="match_parent"
10 android:layout_height="wrap_content" 10 android:layout_height="wrap_content"
(...skipping 28 matching lines...) Expand all
39 android:id="@+id/article_publisher" 39 android:id="@+id/article_publisher"
40 android:layout_width="match_parent" 40 android:layout_width="match_parent"
41 android:layout_height="wrap_content" 41 android:layout_height="wrap_content"
42 android:layout_below="@+id/article_snippet" 42 android:layout_below="@+id/article_snippet"
43 android:layout_toStartOf="@+id/article_thumbnail" 43 android:layout_toStartOf="@+id/article_thumbnail"
44 android:layout_marginTop="16dp" 44 android:layout_marginTop="16dp"
45 android:maxLines="1" 45 android:maxLines="1"
46 android:ellipsize="end" 46 android:ellipsize="end"
47 android:textSize="14sp" 47 android:textSize="14sp"
48 android:textColor="@color/snippets_publisher_name_color" /> 48 android:textColor="@color/snippets_publisher_name_color" />
49 49
50 <ImageView 50 <ImageView
51 android:id="@+id/article_thumbnail" 51 android:id="@+id/article_thumbnail"
52 android:background="@color/snippets_thumnail_placeholder_bg"
52 android:layout_width="@dimen/snippets_thumbnail_size" 53 android:layout_width="@dimen/snippets_thumbnail_size"
53 android:layout_height="@dimen/snippets_thumbnail_size" 54 android:layout_height="@dimen/snippets_thumbnail_size"
54 android:layout_alignParentTop="true" 55 android:layout_alignParentTop="true"
55 android:layout_alignParentEnd="true" 56 android:layout_alignParentEnd="true"
56 android:layout_marginStart="16dp" 57 android:layout_marginStart="16dp"
57 android:scaleType="centerCrop" 58 android:scaleType="centerCrop"
58 android:contentDescription="@null" 59 android:contentDescription="@null"
Theresa 2016/04/11 23:42:27 Does the content description get set elsewhere? Th
dgn 2016/04/12 11:17:14 Not as far as I can see. That being said, it's con
Theresa 2016/04/12 18:11:48 As long as the snippet itself has a content descri
dgn 2016/04/13 16:52:21 TalkBack properly skips it. Looking on the net, it
Theresa 2016/04/13 16:53:09 sg, thanks for testing :)
59 android:src="@null"/> 60 android:src="@null"/>
60 </RelativeLayout> 61 </RelativeLayout>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698