chrome/android/java/res/drawable/ic_snippet_thumbnail_placeholder.xml - Issue 1871343006: [NTP Snippets] 📷 Add placeholders and start caching thumbnails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/drawable/ic_snippet_thumbnail_placeholder.xml

Issue 1871343006: [NTP Snippets] 📷 Add placeholders and start caching thumbnails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move the async task out as it needs to be stopped from the view, not the snippet Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/res/layout/new_tab_page_snippets_card.xml » ('j') | chrome/android/java/res/layout/new_tab_page_snippets_card.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/drawable/ic_snippet_thumbnail_placeholder.xml

diff --git a/chrome/android/java/res/drawable/ic_snippet_thumbnail_placeholder.xml b/chrome/android/java/res/drawable/ic_snippet_thumbnail_placeholder.xml

new file mode 100644

index 0000000000000000000000000000000000000000..542161ab1b7497fabfbd73f6fc5d76ed8a0df4b2

--- /dev/null

+++ b/chrome/android/java/res/drawable/ic_snippet_thumbnail_placeholder.xml

@@ -0,0 +1,17 @@

+<?xml version="1.0" encoding="utf-8"?>

+<vector xmlns:android="http://schemas.android.com/apk/res/android"

+ android:width="72dp"

Theresa 2016/04/11 23:42:27 Use @dimen/snippets_thumbnail_size

dgn 2016/04/12 11:17:14 Done.

+ android:height="72dp"

+ android:viewportWidth="72"

+ android:viewportHeight="72">

+ <path

+ android:pathData="M0,0 L72,0 L72,71.9997 L0,71.9997 Z" />

Theresa 2016/04/11 23:42:27 Can this fit w/ the line above?

dgn 2016/04/12 11:17:14 Done.

+ <path

+ android:fillColor="#757575"

Theresa 2016/04/11 23:42:27 define a color in colors.xml for this

dgn 2016/04/12 11:17:14 Done.

+ android:pathData="M45,42.9997 L45,28.9997 C45,27.8997,44.1,26.9997,43,26.9997 L29,26.9997

+C27.9,26.9997,27,27.8997,27,28.9997 L27,42.9997

+C27,44.0997,27.9,44.9997,29,44.9997 L43,44.9997

+C44.1,44.9997,45,44.0997,45,42.9997 Z M32.5,37.4997 L35,40.5097 L38.5,35.9997

+L43,41.9997 L29,41.9997 L32.5,37.4997 Z" />

+</vector>