chrome/android/java/res/drawable/ic_snippet_thumbnail_placeholder.xml - Issue 1871343006: [NTP Snippets] 📷 Add placeholders and start caching thumbnails

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/drawable/ic_snippet_thumbnail_placeholder.xml

Issue 1871343006: [NTP Snippets] 📷 Add placeholders and start caching thumbnails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move the async task out as it needs to be stopped from the view, not the snippet Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <vector xmlns:android="http://schemas.android.com/apk/res/android"

	3 android:width="72dp"
	Theresa 2016/04/11 23:42:27 Use @dimen/snippets_thumbnail_size Use @dimen/snippets_thumbnail_size dgn 2016/04/12 11:17:14 Done. Show quoted text On 2016/04/11 23:42:27, Theresa Wellington wrote: > Use @dimen/snippets_thumbnail_size Done.
	4 android:height="72dp"

	5 android:viewportWidth="72"

	6 android:viewportHeight="72">

	7

	8 <path

	9 android:pathData="M0,0 L72,0 L72,71.9997 L0,71.9997 Z" />
	Theresa 2016/04/11 23:42:27 Can this fit w/ the line above? Can this fit w/ the line above? dgn 2016/04/12 11:17:14 Done. Show quoted text On 2016/04/11 23:42:27, Theresa Wellington wrote: > Can this fit w/ the line above? Done.
	10 <path

	11 android:fillColor="#757575"
	Theresa 2016/04/11 23:42:27 define a color in colors.xml for this define a color in colors.xml for this dgn 2016/04/12 11:17:14 Done. Show quoted text On 2016/04/11 23:42:27, Theresa Wellington wrote: > define a color in colors.xml for this Done.
	12 android:pathData="M45,42.9997 L45,28.9997 C45,27.8997,44.1,26.9997,43,26 .9997 L29,26.9997

	13 C27.9,26.9997,27,27.8997,27,28.9997 L27,42.9997

	14 C27,44.0997,27.9,44.9997,29,44.9997 L43,44.9997

	15 C44.1,44.9997,45,44.0997,45,42.9997 Z M32.5,37.4997 L35,40.5097 L38.5,35.9997

	16 L43,41.9997 L29,41.9997 L32.5,37.4997 Z" />

	17 </vector>

OLD	NEW