Chromium Code Reviews| Index: chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc |
| diff --git a/chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc b/chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc |
| index 7cda2a7a47ca41f469e02140a33f4558f180aa68..e77c100eb0233e5dbee2e62e27b3e290c4c38388 100644 |
| --- a/chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc |
| +++ b/chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc |
| @@ -164,28 +164,32 @@ TEST_F(PushMessagingPermissionContextTest, DecidePushPermission) { |
| BrowserPermissionCallback callback = base::Bind(DoNothing); |
| context.DecidePushPermission(request_id, GURL(kOriginA), GURL(kOriginA), |
| - callback, CONTENT_SETTING_DEFAULT); |
| + callback, |
| + blink::mojom::PermissionStatus::DENIED); |
|
mlamouri (slow - plz ping)
2016/04/12 11:36:40
Should that be PROMPT?
raymes
2016/04/13 00:35:07
In production code, I don't think this function wi
|
| EXPECT_FALSE(context.was_persisted()); |
| EXPECT_FALSE(context.was_granted()); |
| SetContentSetting(&profile, CONTENT_SETTINGS_TYPE_PUSH_MESSAGING, |
| CONTENT_SETTING_ALLOW); |
| context.DecidePushPermission(request_id, GURL(kOriginA), GURL(kOriginA), |
| - callback, CONTENT_SETTING_ALLOW); |
| + callback, |
| + blink::mojom::PermissionStatus::GRANTED); |
| EXPECT_TRUE(context.was_persisted()); |
| EXPECT_TRUE(context.was_granted()); |
| SetContentSetting(&profile, CONTENT_SETTINGS_TYPE_PUSH_MESSAGING, |
| CONTENT_SETTING_BLOCK); |
| context.DecidePushPermission(request_id, GURL(kOriginA), GURL(kOriginA), |
| - callback, CONTENT_SETTING_ALLOW); |
| + callback, |
| + blink::mojom::PermissionStatus::GRANTED); |
| EXPECT_TRUE(context.was_persisted()); |
| EXPECT_FALSE(context.was_granted()); |
| SetContentSetting(&profile, CONTENT_SETTINGS_TYPE_PUSH_MESSAGING, |
| CONTENT_SETTING_ASK); |
| context.DecidePushPermission(request_id, GURL(kOriginA), GURL(kOriginA), |
| - callback, CONTENT_SETTING_ALLOW); |
| + callback, |
| + blink::mojom::PermissionStatus::GRANTED); |
| EXPECT_TRUE(context.was_persisted()); |
| EXPECT_TRUE(context.was_granted()); |
| } |