Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc

Issue 1871343002: Remove PermissionContext factories (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc
diff --git a/chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc b/chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc
index 7cda2a7a47ca41f469e02140a33f4558f180aa68..e77c100eb0233e5dbee2e62e27b3e290c4c38388 100644
--- a/chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc
+++ b/chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc
@@ -164,28 +164,32 @@ TEST_F(PushMessagingPermissionContextTest, DecidePushPermission) {
BrowserPermissionCallback callback = base::Bind(DoNothing);
context.DecidePushPermission(request_id, GURL(kOriginA), GURL(kOriginA),
- callback, CONTENT_SETTING_DEFAULT);
+ callback,
+ blink::mojom::PermissionStatus::DENIED);
mlamouri (slow - plz ping) 2016/04/12 11:36:40 Should that be PROMPT?
raymes 2016/04/13 00:35:07 In production code, I don't think this function wi
EXPECT_FALSE(context.was_persisted());
EXPECT_FALSE(context.was_granted());
SetContentSetting(&profile, CONTENT_SETTINGS_TYPE_PUSH_MESSAGING,
CONTENT_SETTING_ALLOW);
context.DecidePushPermission(request_id, GURL(kOriginA), GURL(kOriginA),
- callback, CONTENT_SETTING_ALLOW);
+ callback,
+ blink::mojom::PermissionStatus::GRANTED);
EXPECT_TRUE(context.was_persisted());
EXPECT_TRUE(context.was_granted());
SetContentSetting(&profile, CONTENT_SETTINGS_TYPE_PUSH_MESSAGING,
CONTENT_SETTING_BLOCK);
context.DecidePushPermission(request_id, GURL(kOriginA), GURL(kOriginA),
- callback, CONTENT_SETTING_ALLOW);
+ callback,
+ blink::mojom::PermissionStatus::GRANTED);
EXPECT_TRUE(context.was_persisted());
EXPECT_FALSE(context.was_granted());
SetContentSetting(&profile, CONTENT_SETTINGS_TYPE_PUSH_MESSAGING,
CONTENT_SETTING_ASK);
context.DecidePushPermission(request_id, GURL(kOriginA), GURL(kOriginA),
- callback, CONTENT_SETTING_ALLOW);
+ callback,
+ blink::mojom::PermissionStatus::GRANTED);
EXPECT_TRUE(context.was_persisted());
EXPECT_TRUE(context.was_granted());
}

Powered by Google App Engine
This is Rietveld 408576698