Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4694)

Unified Diff: chrome/browser/permissions/permission_manager.h

Issue 1871343002: Remove PermissionContext factories (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_manager.h
diff --git a/chrome/browser/permissions/permission_manager.h b/chrome/browser/permissions/permission_manager.h
index 4123cf721b920aca71809221dd035f5a7755826a..3cb6e94b12b805b36d9d9214bbc9fa5c3ed1bad7 100644
--- a/chrome/browser/permissions/permission_manager.h
+++ b/chrome/browser/permissions/permission_manager.h
@@ -5,6 +5,8 @@
#ifndef CHROME_BROWSER_PERMISSIONS_PERMISSION_MANAGER_H_
#define CHROME_BROWSER_PERMISSIONS_PERMISSION_MANAGER_H_
+#include <map>
+
#include "base/callback_forward.h"
#include "base/id_map.h"
#include "base/macros.h"
@@ -14,6 +16,7 @@
#include "components/keyed_service/core/keyed_service.h"
#include "content/public/browser/permission_manager.h"
+class PermissionContextBase;
class Profile;
namespace content {
@@ -25,6 +28,8 @@ class PermissionManager : public KeyedService,
public content::PermissionManager,
public content_settings::Observer {
public:
+ static PermissionManager* Get(Profile* profile);
+
explicit PermissionManager(Profile* profile);
~PermissionManager() override;
@@ -62,12 +67,18 @@ class PermissionManager : public KeyedService,
void UnsubscribePermissionStatusChange(int subscription_id) override;
private:
+ friend class GeolocationPermissionContextTests;
+ // TODO(raymes): Delete this after refactoring MediaPermission!
mlamouri (slow - plz ping) 2016/04/12 11:36:39 Link to a bug number?
raymes 2016/04/13 00:35:07 Done.
+ friend class MediaPermission;
+
class PendingRequest;
using PendingRequestsMap = IDMap<PendingRequest, IDMapOwnPointer>;
struct Subscription;
using SubscriptionsMap = IDMap<Subscription, IDMapOwnPointer>;
+ PermissionContextBase* GetPermissionContext(content::PermissionType type);
+
// Called when a permission was decided for a given PendingRequest. The
// PendingRequest is identified by its |request_id| and the permission is
// identified by its |permission_id|. If the PendingRequest contains more than
@@ -93,6 +104,9 @@ class PermissionManager : public KeyedService,
PendingRequestsMap pending_requests_;
SubscriptionsMap subscriptions_;
+ std::map<content::PermissionType, scoped_ptr<PermissionContextBase>>
+ permission_contexts_;
+
base::WeakPtrFactory<PermissionManager> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(PermissionManager);

Powered by Google App Engine
This is Rietveld 408576698