Remove PermissionContext factories

chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/push_messaging/push_messaging_permission_context.h"
 
 #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
 #include "chrome/browser/permissions/permission_request_id.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "chrome/test/base/testing_profile.h"
@@ skipping 146 matching lines @@
             context.GetPermissionStatus(GURL(kOriginA), GURL(kOriginA)));
 }
 
 TEST_F(PushMessagingPermissionContextTest, DecidePushPermission) {
   TestingProfile profile;
   TestPushMessagingPermissionContext context(&profile);
   PermissionRequestID request_id(-1, -1, -1);
   BrowserPermissionCallback callback = base::Bind(DoNothing);
 
   context.DecidePushPermission(request_id, GURL(kOriginA), GURL(kOriginA),
-                               callback, CONTENT_SETTING_DEFAULT);
+                               callback,
+                               blink::mojom::PermissionStatus::DENIED);

[mlamouri (slow - plz ping), 2016/04/12 11:36:40]

Should that be PROMPT?

[raymes, 2016/04/13 00:35:07]

In production code, I don't think this function will ever be called with prompt.
The result of calling RequestPermission on notifications should always be
granted or denied right?

   EXPECT_FALSE(context.was_persisted());
   EXPECT_FALSE(context.was_granted());
 
   SetContentSetting(&profile, CONTENT_SETTINGS_TYPE_PUSH_MESSAGING,
                     CONTENT_SETTING_ALLOW);
   context.DecidePushPermission(request_id, GURL(kOriginA), GURL(kOriginA),
-                               callback, CONTENT_SETTING_ALLOW);
+                               callback,
+                               blink::mojom::PermissionStatus::GRANTED);
   EXPECT_TRUE(context.was_persisted());
   EXPECT_TRUE(context.was_granted());
 
   SetContentSetting(&profile, CONTENT_SETTINGS_TYPE_PUSH_MESSAGING,
                     CONTENT_SETTING_BLOCK);
   context.DecidePushPermission(request_id, GURL(kOriginA), GURL(kOriginA),
-                               callback, CONTENT_SETTING_ALLOW);
+                               callback,
+                               blink::mojom::PermissionStatus::GRANTED);
   EXPECT_TRUE(context.was_persisted());
   EXPECT_FALSE(context.was_granted());
 
   SetContentSetting(&profile, CONTENT_SETTINGS_TYPE_PUSH_MESSAGING,
                     CONTENT_SETTING_ASK);
   context.DecidePushPermission(request_id, GURL(kOriginA), GURL(kOriginA),
-                               callback, CONTENT_SETTING_ALLOW);
+                               callback,
+                               blink::mojom::PermissionStatus::GRANTED);
   EXPECT_TRUE(context.was_persisted());
   EXPECT_TRUE(context.was_granted());
 }
 
 TEST_F(PushMessagingPermissionContextTest, DecidePermission) {
   TestingProfile profile;
   TestPushMessagingPermissionContext context(&profile);
   PermissionRequestID request_id(-1, -1, -1);
   BrowserPermissionCallback callback = base::Bind(DoNothing);
 
@@ skipping 102 matching lines @@
   EXPECT_EQ(CONTENT_SETTING_BLOCK,
             context.GetPermissionStatus(GURL(kInsecureOrigin),
                                         GURL(kInsecureOrigin)));
 
   SetContentSetting(&profile, CONTENT_SETTINGS_TYPE_PUSH_MESSAGING,
                     CONTENT_SETTING_ASK);
   EXPECT_EQ(CONTENT_SETTING_BLOCK,
             context.GetPermissionStatus(GURL(kInsecureOrigin),
                                         GURL(kInsecureOrigin)));
 }