aura: Require explicit ownership of the Env instance.

aura: Require explicit ownership of the Env instance.

Notable changes:
. Change aura::Env::CreateInstance() to return a std::unique_ptr<> to the aura::Env
  instance, so that there's a clear owner of the instance, and random code can no
  longer destroy it.
. Make aura::Env::CreateInstance() fail if more than one instance is attempted to be
  created.
. Remove the boolean parameter to aura::Env::CreateInstance(), since that is no longer
  necessary, and always create a PlatformEventSource instance (if one hasn't already
  been created).
. BrowserMainLoop takes care of creating/destroying the aura::Env instance. So the
  various BrowserMainParts implementations no longer need to do that.

BUG=601983
Committed: https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364
Cr-Commit-Position: refs/heads/master@{#386502}

[sadrul, 2016-04-09 03:09:32]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[sadrul, 2016-04-09 03:09:33]

I attempted this earlier (https://codereview.chromium.org/1293013002/), but it
broke mandoline, and was reverted. Now that mandoline is no more, it should be
good to go again. This also helps fix launching chrome inside mash (there are
still some things broken, I am looking at them separately: e.g.
https://codereview.chromium.org/1874813002/).

For this CL, the changes in aura::Env::Init, and views::WindowManagerConnection
are probably more interesting.

[sadrul, 2016-04-09 03:09:56]

Description was changed from

==========
aura: Require explicit ownership of the Env instance.

Notable changes:
. Change aura::Env::CreateInstance() to return a std::unique_ptr<> to the
aura::Env
  instance, so that there's a clear owner of the instance, and random code can
no
  Jlonger destroy
  it.
. Make aura::Env::CreateInstance() fail if more than one instance is attempted
to be
  created.
. Remove the boolean parameter to aura::Env::CreateInstance(), since that is no
longer
  necessary, and always create a PlatformEventSource instance (if one hasn't
already
  been created).
. BrowserMainLoop takes care of creating/destroying the aura::Env instance. So
the
  various BrowserMainParts implementations no longer need to do that.

BUG=none
==========

to

==========
aura: Require explicit ownership of the Env instance.

Notable changes:
. Change aura::Env::CreateInstance() to return a std::unique_ptr<> to the
aura::Env
  instance, so that there's a clear owner of the instance, and random code can
no
  Jlonger destroy
  it.
. Make aura::Env::CreateInstance() fail if more than one instance is attempted
to be
  created.
. Remove the boolean parameter to aura::Env::CreateInstance(), since that is no
longer
  necessary, and always create a PlatformEventSource instance (if one hasn't
already
  been created).
. BrowserMainLoop takes care of creating/destroying the aura::Env instance. So
the
  various BrowserMainParts implementations no longer need to do that.

BUG=601983
==========

[sadrul, 2016-04-09 03:10:30]

Description was changed from

==========
aura: Require explicit ownership of the Env instance.

Notable changes:
. Change aura::Env::CreateInstance() to return a std::unique_ptr<> to the
aura::Env
  instance, so that there's a clear owner of the instance, and random code can
no
  Jlonger destroy
  it.
. Make aura::Env::CreateInstance() fail if more than one instance is attempted
to be
  created.
. Remove the boolean parameter to aura::Env::CreateInstance(), since that is no
longer
  necessary, and always create a PlatformEventSource instance (if one hasn't
already
  been created).
. BrowserMainLoop takes care of creating/destroying the aura::Env instance. So
the
  various BrowserMainParts implementations no longer need to do that.

BUG=601983
==========

to

==========
aura: Require explicit ownership of the Env instance.

Notable changes:
. Change aura::Env::CreateInstance() to return a std::unique_ptr<> to the
aura::Env
  instance, so that there's a clear owner of the instance, and random code can
no
  longer destroy it.
. Make aura::Env::CreateInstance() fail if more than one instance is attempted
to be
  created.
. Remove the boolean parameter to aura::Env::CreateInstance(), since that is no
longer
  necessary, and always create a PlatformEventSource instance (if one hasn't
already
  been created).
. BrowserMainLoop takes care of creating/destroying the aura::Env instance. So
the
  various BrowserMainParts implementations no longer need to do that.

BUG=601983
==========

[sky, 2016-04-11 15:18:05]

LGTM

[sadrul, 2016-04-11 16:32:27]

sadrul@chromium.org changed reviewers:
+ ben@chromium.org

[sadrul, 2016-04-11 16:32:28]

+ben@ as toplevel owner for chromecast/, content/, and headless/ changes.

[Ben Goodger (Google), 2016-04-11 19:59:07]

lgtm

[sadrul, 2016-04-11 20:22:46]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2016-04-11 20:23:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1871253002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1871253002/40001

[commit-bot: I haz the power, 2016-04-11 20:27:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-11 20:27:36]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[sadrul, 2016-04-11 22:35:29]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2016-04-11 22:35:29]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
ben@chromium.org
Link to the patchset: https://codereview.chromium.org/1871253002/#ps60001
(title: "tot.merge")

[commit-bot: I haz the power, 2016-04-11 22:36:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1871253002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1871253002/60001

[commit-bot: I haz the power, 2016-04-11 22:44:06]

Description was changed from

==========
aura: Require explicit ownership of the Env instance.

Notable changes:
. Change aura::Env::CreateInstance() to return a std::unique_ptr<> to the
aura::Env
  instance, so that there's a clear owner of the instance, and random code can
no
  longer destroy it.
. Make aura::Env::CreateInstance() fail if more than one instance is attempted
to be
  created.
. Remove the boolean parameter to aura::Env::CreateInstance(), since that is no
longer
  necessary, and always create a PlatformEventSource instance (if one hasn't
already
  been created).
. BrowserMainLoop takes care of creating/destroying the aura::Env instance. So
the
  various BrowserMainParts implementations no longer need to do that.

BUG=601983
==========

to

==========
aura: Require explicit ownership of the Env instance.

Notable changes:
. Change aura::Env::CreateInstance() to return a std::unique_ptr<> to the
aura::Env
  instance, so that there's a clear owner of the instance, and random code can
no
  longer destroy it.
. Make aura::Env::CreateInstance() fail if more than one instance is attempted
to be
  created.
. Remove the boolean parameter to aura::Env::CreateInstance(), since that is no
longer
  necessary, and always create a PlatformEventSource instance (if one hasn't
already
  been created).
. BrowserMainLoop takes care of creating/destroying the aura::Env instance. So
the
  various BrowserMainParts implementations no longer need to do that.

BUG=601983
==========

[commit-bot: I haz the power, 2016-04-11 22:44:09]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-11 22:45:09]

Description was changed from

==========
aura: Require explicit ownership of the Env instance.

Notable changes:
. Change aura::Env::CreateInstance() to return a std::unique_ptr<> to the
aura::Env
  instance, so that there's a clear owner of the instance, and random code can
no
  longer destroy it.
. Make aura::Env::CreateInstance() fail if more than one instance is attempted
to be
  created.
. Remove the boolean parameter to aura::Env::CreateInstance(), since that is no
longer
  necessary, and always create a PlatformEventSource instance (if one hasn't
already
  been created).
. BrowserMainLoop takes care of creating/destroying the aura::Env instance. So
the
  various BrowserMainParts implementations no longer need to do that.

BUG=601983
==========

to

==========
aura: Require explicit ownership of the Env instance.

Notable changes:
. Change aura::Env::CreateInstance() to return a std::unique_ptr<> to the
aura::Env
  instance, so that there's a clear owner of the instance, and random code can
no
  longer destroy it.
. Make aura::Env::CreateInstance() fail if more than one instance is attempted
to be
  created.
. Remove the boolean parameter to aura::Env::CreateInstance(), since that is no
longer
  necessary, and always create a PlatformEventSource instance (if one hasn't
already
  been created).
. BrowserMainLoop takes care of creating/destroying the aura::Env instance. So
the
  various BrowserMainParts implementations no longer need to do that.

BUG=601983

Committed: https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364
Cr-Commit-Position: refs/heads/master@{#386502}
==========

[commit-bot: I haz the power, 2016-04-11 22:45:11]

Patchset 4 (id:??) landed as
https://crrev.com/578205fa70099bc2c93f785e6860ea878e6b7364
Cr-Commit-Position: refs/heads/master@{#386502}