ash/shell/content/client/shell_browser_main_parts.cc - Issue 1871253002: aura: Require explicit ownership of the Env instance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shell/content/client/shell_browser_main_parts.cc

Issue 1871253002: aura: Require explicit ownership of the Env instance. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tot.merge Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/shell/content/client/shell_browser_main_parts.cc

diff --git a/ash/shell/content/client/shell_browser_main_parts.cc b/ash/shell/content/client/shell_browser_main_parts.cc

index 636a7c9de79e9e4f0a49d0902675afb04e2093b5..6cb215e950d0a56759b33341858c88eccad291f4 100644

--- a/ash/shell/content/client/shell_browser_main_parts.cc

+++ b/ash/shell/content/client/shell_browser_main_parts.cc

@@ -159,8 +159,6 @@ void ShellBrowserMainParts::PostMainMessageLoopRun() {

chromeos::CrasAudioHandler::Shutdown();

#endif

- aura::Env::DeleteInstance();

views_delegate_.reset();

// The keyboard may have created a WebContents. The WebContents is destroyed

« no previous file with comments | « no previous file | ash/test/ash_interactive_ui_test_base.h » ('j') | no next file with comments »