ui/views_content_client/views_content_client_main_parts_desktop_aura.cc - Issue 1871253002: aura: Require explicit ownership of the Env instance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views_content_client/views_content_client_main_parts_desktop_aura.cc

Issue 1871253002: aura: Require explicit ownership of the Env instance. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tot.merge Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views_content_client/views_content_client_main_parts_desktop_aura.cc

diff --git a/ui/views_content_client/views_content_client_main_parts_desktop_aura.cc b/ui/views_content_client/views_content_client_main_parts_desktop_aura.cc

index c7a3d0c7ee3f57e19649c105f9ea4e7bef0d35d2..5688cedf40ffd0514c661764a49790a85a694c5d 100644

--- a/ui/views_content_client/views_content_client_main_parts_desktop_aura.cc

+++ b/ui/views_content_client/views_content_client_main_parts_desktop_aura.cc

@@ -4,7 +4,6 @@

#include "base/macros.h"

#include "content/shell/browser/shell_browser_context.h"

-#include "ui/aura/env.h"

#include "ui/gfx/screen.h"

#include "ui/views/widget/desktop_aura/desktop_screen.h"

#include "ui/views_content_client/views_content_client.h"

@@ -38,7 +37,6 @@ ViewsContentClientMainPartsDesktopAura::ViewsContentClientMainPartsDesktopAura(

void ViewsContentClientMainPartsDesktopAura::PreMainMessageLoopRun() {

ViewsContentClientMainPartsAura::PreMainMessageLoopRun();

- aura::Env::CreateInstance(true);

gfx::Screen::SetScreenInstance(views::CreateDesktopScreen());

views_content_client()->task().Run(browser_context(), NULL);

« no previous file with comments | « ui/views_content_client/views_content_client_main_parts_aura.cc ('k') | ui/wm/test/run_all_unittests.cc » ('j') | no next file with comments »