Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1871143002: [Mac/GN] Use the right output name for Mac frameworks. (Closed)

Created:
4 years, 8 months ago by Robert Sesek
Modified:
4 years, 8 months ago
Reviewers:
sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Use the right output name for Mac frameworks. This uses the new output_prefix_override flag to not prefix framework shared libraries with "lib" and overrides the output_extension to be empty. BUG=297668 Committed: https://crrev.com/c7905381e103462334ea24c20f1de670d89bd1ec Cr-Commit-Position: refs/heads/master@{#386692}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M build/config/mac/rules.gni View 1 1 chunk +4 lines, -1 line 0 comments Download
M ui/base/BUILD.gn View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Robert Sesek
4 years, 8 months ago (2016-04-12 14:11:57 UTC) #3
sdefresne
lgtm
4 years, 8 months ago (2016-04-12 14:19:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871143002/20001
4 years, 8 months ago (2016-04-12 14:49:29 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-12 15:28:29 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 15:29:39 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c7905381e103462334ea24c20f1de670d89bd1ec
Cr-Commit-Position: refs/heads/master@{#386692}

Powered by Google App Engine
This is Rietveld 408576698