Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: ui/base/BUILD.gn

Issue 1871143002: [Mac/GN] Use the right output name for Mac frameworks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/mac/rules.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/BUILD.gn
diff --git a/ui/base/BUILD.gn b/ui/base/BUILD.gn
index 100beb395927a12b56e5586762f64b40d519db81..fa9817394bcf29ec67cd7517d4703af78ddff285 100644
--- a/ui/base/BUILD.gn
+++ b/ui/base/BUILD.gn
@@ -893,7 +893,7 @@ test("ui_base_unittests") {
if (is_mac) {
deps += [
- ":ui_unittests Framework",
+ ":ui_unittests_framework",
"//third_party/mozilla",
]
}
@@ -951,11 +951,12 @@ test("ui_base_unittests") {
}
if (is_mac) {
- mac_framework_bundle("ui_unittests Framework") {
+ mac_framework_bundle("ui_unittests_framework") {
testonly = true
deps = [
"//ui/resources:ui_test_pak_bundle_data",
]
info_plist = "test/framework-Info.plist"
+ output_name = "ui_unittests Framework"
}
}
« no previous file with comments | « build/config/mac/rules.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698