Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1504)

Unified Diff: build/config/mac/rules.gni

Issue 1871143002: [Mac/GN] Use the right output name for Mac frameworks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/base/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/mac/rules.gni
diff --git a/build/config/mac/rules.gni b/build/config/mac/rules.gni
index 5d616049cb886322ca77ca6de3f570d118b422a2..6ffe613e0b8e9208c6036d104d68453ce078fce3 100644
--- a/build/config/mac/rules.gni
+++ b/build/config/mac/rules.gni
@@ -54,13 +54,16 @@ template("framework_bundle") {
"output_name",
"visibility",
])
+ output_name = _output_name
+ output_prefix_override = true
+ output_extension = ""
}
bundle_data(_shared_library_bundle_data) {
visibility = [ ":$_framework_target" ]
forward_variables_from(invoker, [ "testonly" ])
sources = [
- "$root_out_dir/${shlib_prefix}${_shared_library_target}${shlib_extension}",
+ "$root_out_dir/${_output_name}",
]
outputs = [
"{{bundle_executable_dir}}/$_output_name",
« no previous file with comments | « no previous file | ui/base/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698