Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1871073004: Settings People Revamp: Simplify Change Picture browsertests. (Closed)

Created:
4 years, 8 months ago by tommycli
Modified:
4 years, 8 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@0138-settings-people-manage-profile-browser-tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings People Revamp: Simplify Change Picture browsertests. The old version used the real objects, was slow, and a bit flaky. This new version uses the TestBrowserProxy pattern established by dpapad, so hopefully this solves the flakiness and unblocks the Polymer roll. BUG=563721 Committed: https://crrev.com/0b46662789c37358cf4f9d8fb7f4e03506dfec81 Cr-Commit-Position: refs/heads/master@{#386546}

Patch Set 1 #

Patch Set 2 : #

Total comments: 13

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : fix hitting the check (and merge origin/master) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -208 lines) Patch
M chrome/browser/resources/settings/people_page/camera.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/people_page/change_picture.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/people_page/change_picture.js View 1 2 3 3 chunks +6 lines, -12 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/webui/settings/change_picture_browsertest_chromeos.js View 1 chunk +0 lines, -192 lines 0 comments Download
M chrome/test/data/webui/settings/cr_settings_browsertest.js View 1 2 3 4 1 chunk +29 lines, -1 line 0 comments Download
A chrome/test/data/webui/settings/people_page_change_picture_test.js View 1 2 3 4 1 chunk +225 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871073004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871073004/20001
4 years, 8 months ago (2016-04-08 23:57:12 UTC) #2
tommycli
dpapad: PTAL. This change is to simplify these tests and unblock your Polymer roll. There's ...
4 years, 8 months ago (2016-04-08 23:57:52 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/16622) ios_dbg_simulator_ninja on ...
4 years, 8 months ago (2016-04-08 23:59:30 UTC) #6
dpapad
https://codereview.chromium.org/1871073004/diff/20001/chrome/browser/resources/settings/people_page/change_picture.js File chrome/browser/resources/settings/people_page/change_picture.js (right): https://codereview.chromium.org/1871073004/diff/20001/chrome/browser/resources/settings/people_page/change_picture.js#newcode50 chrome/browser/resources/settings/people_page/change_picture.js:50: selectedItem_: { Shouldn't this be /** * @private {settings.ChangePictureImageElement} ...
4 years, 8 months ago (2016-04-09 00:16:35 UTC) #7
tommycli
dpapad: Done, thanks! https://codereview.chromium.org/1871073004/diff/20001/chrome/browser/resources/settings/people_page/change_picture.js File chrome/browser/resources/settings/people_page/change_picture.js (right): https://codereview.chromium.org/1871073004/diff/20001/chrome/browser/resources/settings/people_page/change_picture.js#newcode50 chrome/browser/resources/settings/people_page/change_picture.js:50: selectedItem_: { On 2016/04/09 00:16:35, dpapad ...
4 years, 8 months ago (2016-04-11 19:09:58 UTC) #8
dpapad
LGTM https://codereview.chromium.org/1871073004/diff/20001/chrome/browser/resources/settings/people_page/change_picture.js File chrome/browser/resources/settings/people_page/change_picture.js (right): https://codereview.chromium.org/1871073004/diff/20001/chrome/browser/resources/settings/people_page/change_picture.js#newcode355 chrome/browser/resources/settings/people_page/change_picture.js:355: return cameraPresent && selectedItem != null && On ...
4 years, 8 months ago (2016-04-11 19:36:39 UTC) #9
tommycli
https://codereview.chromium.org/1871073004/diff/20001/chrome/browser/resources/settings/people_page/change_picture.js File chrome/browser/resources/settings/people_page/change_picture.js (right): https://codereview.chromium.org/1871073004/diff/20001/chrome/browser/resources/settings/people_page/change_picture.js#newcode355 chrome/browser/resources/settings/people_page/change_picture.js:355: return cameraPresent && selectedItem != null && On 2016/04/11 ...
4 years, 8 months ago (2016-04-11 21:20:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871073004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871073004/60001
4 years, 8 months ago (2016-04-11 21:22:01 UTC) #13
dpapad
https://codereview.chromium.org/1871073004/diff/20001/chrome/browser/resources/settings/people_page/change_picture.js File chrome/browser/resources/settings/people_page/change_picture.js (right): https://codereview.chromium.org/1871073004/diff/20001/chrome/browser/resources/settings/people_page/change_picture.js#newcode355 chrome/browser/resources/settings/people_page/change_picture.js:355: return cameraPresent && selectedItem != null && On 2016/04/11 ...
4 years, 8 months ago (2016-04-11 21:29:34 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/194935)
4 years, 8 months ago (2016-04-11 22:28:55 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871073004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871073004/80001
4 years, 8 months ago (2016-04-12 00:03:02 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-12 01:47:44 UTC) #20
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 01:48:52 UTC) #22
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/0b46662789c37358cf4f9d8fb7f4e03506dfec81
Cr-Commit-Position: refs/heads/master@{#386546}

Powered by Google App Engine
This is Rietveld 408576698