Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7036)

Unified Diff: chrome/browser/resources/settings/people_page/change_picture.js

Issue 1871073004: Settings People Revamp: Simplify Change Picture browsertests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0138-settings-people-manage-profile-browser-tests
Patch Set: fix hitting the check (and merge origin/master) Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/people_page/change_picture.html ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/people_page/change_picture.js
diff --git a/chrome/browser/resources/settings/people_page/change_picture.js b/chrome/browser/resources/settings/people_page/change_picture.js
index 57d0e24f8b57914b868ba88a94f4ff80f6171e96..22326245ee31390ec5ec634b7b5d1506c5711def 100644
--- a/chrome/browser/resources/settings/people_page/change_picture.js
+++ b/chrome/browser/resources/settings/people_page/change_picture.js
@@ -44,13 +44,11 @@ Polymer({
/**
* The currently selected item. This property is bound to the iron-selector
- * and never directly assigned.
- * @private {settings.ChangePictureImageElement}
+ * and never directly assigned. This may be undefined momentarily as
+ * the selection changes due to iron-selector implementation details.
+ * @private {?settings.ChangePictureImageElement}
*/
- selectedItem_: {
- type: settings.ChangePictureImageElement,
- notify: !!settings_test.changePictureNotifyForTest,
- },
+ selectedItem_: Object,
/**
* The url of the 'old' image, which is the existing image sourced from
@@ -87,10 +85,7 @@ Polymer({
* This may be null if the user started with the 'old' image.
* @private {?settings.ChangePictureImageElement}
*/
- fallbackImage_: {
- type: settings.ChangePictureImageElement,
- value: null,
- },
+ fallbackImage_: Object,
/**
* Type of the last selected icon. This is used to jump back to the camera
@@ -322,8 +317,7 @@ Polymer({
assert(this.defaultImages_.length > 0);
this.browserProxy_.selectDefaultImage(this.defaultImages_[0].url);
- announceAccessibleMessage(
- loadTimeData.getString('photoDiscardAccessibleText'));
+ announceAccessibleMessage(this.i18n('photoDiscardAccessibleText'));
},
/**
« no previous file with comments | « chrome/browser/resources/settings/people_page/change_picture.html ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698