Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8885)

Unified Diff: chrome/test/data/webui/settings/cr_settings_browsertest.js

Issue 1871073004: Settings People Revamp: Simplify Change Picture browsertests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0138-settings-people-manage-profile-browser-tests
Patch Set: fix hitting the check (and merge origin/master) Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/cr_settings_browsertest.js
diff --git a/chrome/test/data/webui/settings/cr_settings_browsertest.js b/chrome/test/data/webui/settings/cr_settings_browsertest.js
index b0475cc085444c43021ceaae1bddf04bbc374dc2..20de8cbb40756895cedc393a3099c272c097064c 100644
--- a/chrome/test/data/webui/settings/cr_settings_browsertest.js
+++ b/chrome/test/data/webui/settings/cr_settings_browsertest.js
@@ -67,7 +67,35 @@ TEST_F('CrSettingsBrowserTest', 'MAYBE_CrSettingsTest', function() {
mocha.run();
});
-GEN('#if !defined(OS_CHROMEOS)');
+GEN('#if defined(OS_CHROMEOS)');
+/**
+ * Test fixture for
+ * chrome/browser/resources/settings/people_page/change_picture.html.
+ * This is ChromeOS only.
+ * @constructor
+ * @extends {CrSettingsBrowserTest}
+*/
+function CrSettingsPeoplePageChangePictureTest() {}
+
+CrSettingsPeoplePageChangePictureTest.prototype = {
+ __proto__: CrSettingsBrowserTest.prototype,
+
+ /** @override */
+ browsePreload: 'chrome://md-settings/people_page/change_picture.html',
+
+ /** @override */
+ extraLibraries: PolymerTest.getLibraries(ROOT_PATH).concat([
+ ROOT_PATH + 'ui/webui/resources/js/promise_resolver.js',
+ 'test_browser_proxy.js',
+ 'people_page_change_picture_test.js',
+ ]),
+};
+
+TEST_F('CrSettingsPeoplePageChangePictureTest', 'ChangePicture', function() {
+ settings_people_page_change_picture.registerTests();
+ mocha.run();
+});
+GEN('#else'); // !defined(OS_CHROMEOS)
/**
* Test fixture for
* chrome/browser/resources/settings/people_page/manage_profile.html.

Powered by Google App Engine
This is Rietveld 408576698