id of iframe incorrectly sets window name

id of iframe incorrectly sets window name

As per the specification, the iframe's name should be an empty string if unset:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#attr-iframe-name

Instead, Chromium was using the iframe's id as window name if the name was
unset. This change makes us behave like Firefox 27 and IE 11, verified using:
http://jsfiddle.net/xf5H7/9/

This CL sets the name attribute iframe in a lot of layout tests so that
testRunner.dumpChildFramesAsText() keeps printing the same result.

R=arv@chromium.org, tkent@chromium.org
BUG=347169
TEST=fast/frames/iframe-no-name.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168553

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168801

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169304

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169683

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169803

[arv (Not doing code reviews), 2014-03-05 14:57:15]

LGTM

[tkent, 2014-03-05 23:34:53]

lgtm

[Inactive, 2014-03-06 01:49:36]

Committed patchset #8 manually as r168553 (presubmit successful).

[Inactive, 2014-03-06 17:44:06]

Reopening as this patch was rolled out for breaking browser_tests on Chrome
side.

I will reland this change once my patch for updating the browser_tests lands on
Chromium-side:
https://codereview.chromium.org/188813003

[Inactive, 2014-03-09 04:51:24]

Committed patchset #9 manually as r168801 (presubmit successful).

[haraken, 2014-03-10 11:05:41]

On 2014/03/09 04:51:24, Chris Dumez wrote:
> Committed patchset #9 manually as r168801 (presubmit successful).

Unfortunately I had to revert this CL in r168829 because it broke browser_tests
in chromium OS:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

[Inactive, 2014-03-15 14:21:08]

Committed patchset #13 manually as r169304 (presubmit successful).

[Inactive, 2014-03-20 17:11:58]

I landed a fix for the ChromeOS issue
(https://codereview.chromium.org/203693004/), I should be able to reland this
today.

[Inactive, 2014-03-20 19:46:03]

Committed patchset #16 manually as r169683 (presubmit successful).

[eseidel, 2014-03-21 07:19:37]

A revert of this CL has been created in
https://codereview.chromium.org/196523007/ by eseidel@chromium.org.

The reason for reverting is: This may have broken browser_tests:
http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%2....

[vsevik, 2014-03-21 07:51:22]

A revert of this CL has been created in
https://codereview.chromium.org/198183003/ by vsevik@chromium.org.

The reason for reverting is: This have broken browser_tests according to my
bisect: 
http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%2....

[Avi (use Gerrit), 2014-03-21 15:02:57]

Which browser tests were broken? I'm working on moving browser tests to use
frame names, and I fear this might be related.

[Inactive, 2014-03-21 15:07:34]

On 2014/03/21 15:02:57, Avi wrote:
> Which browser tests were broken? I'm working on moving browser tests to use
> frame names, and I fear this might be related.

GeolocationBrowserTest.TabDestroyed, see
http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%2...

[Avi (use Gerrit), 2014-03-21 15:11:36]

On 2014/03/21 15:07:34, Chris Dumez wrote:
> On 2014/03/21 15:02:57, Avi wrote:
> > Which browser tests were broken? I'm working on moving browser tests to use
> > frame names, and I fear this might be related.
> 
> GeolocationBrowserTest.TabDestroyed, see
>
http://build.chromium.org/p/chromium.webkit/builders/Linux%2520Tests%2520%252...

That link is a 404 so I can't see there. However, that is my browser_test. :(

In http://crrev.com/203693004, several frames had names set on them. If you set
the frame names in the files of chrome/test/data/geolocation, does that make
things pass with this patch? I fear that my tests are wrong and this patch is
right.

[Inactive, 2014-03-21 15:13:05]

On 2014/03/21 15:07:34, Chris Dumez wrote:
> On 2014/03/21 15:02:57, Avi wrote:
> > Which browser tests were broken? I'm working on moving browser tests to use
> > frame names, and I fear this might be related.
> 
> GeolocationBrowserTest.TabDestroyed, see
>
http://build.chromium.org/p/chromium.webkit/builders/Linux%2520Tests%2520%252...

It is a problem in chrome/test/data/geolocation/tab_destroyed.html, I will fix
it. At least the issues with ChromeOS are gone now so this is progress.

[Avi (use Gerrit), 2014-03-21 15:15:58]

On 2014/03/21 15:13:05, Chris Dumez wrote:
> On 2014/03/21 15:07:34, Chris Dumez wrote:
> > On 2014/03/21 15:02:57, Avi wrote:
> > > Which browser tests were broken? I'm working on moving browser tests to
use
> > > frame names, and I fear this might be related.
> > 
> > GeolocationBrowserTest.TabDestroyed, see
> >
>
http://build.chromium.org/p/chromium.webkit/builders/Linux%252520Tests%252520...
> 
> It is a problem in chrome/test/data/geolocation/tab_destroyed.html, I will fix
> it. At least the issues with ChromeOS are gone now so this is progress.

chrome/test/data/geolocation/iframes_different_origin.html also has two iframes
with id; can you fix those to be named as well?

[Inactive, 2014-03-21 15:18:39]

On 2014/03/21 15:15:58, Avi wrote:
> On 2014/03/21 15:13:05, Chris Dumez wrote:
> > On 2014/03/21 15:07:34, Chris Dumez wrote:
> > > On 2014/03/21 15:02:57, Avi wrote:
> > > > Which browser tests were broken? I'm working on moving browser tests to
> use
> > > > frame names, and I fear this might be related.
> > > 
> > > GeolocationBrowserTest.TabDestroyed, see
> > >
> >
>
http://build.chromium.org/p/chromium.webkit/builders/Linux%25252520Tests%2525...
> > 
> > It is a problem in chrome/test/data/geolocation/tab_destroyed.html, I will
fix
> > it. At least the issues with ChromeOS are gone now so this is progress.
> 
> chrome/test/data/geolocation/iframes_different_origin.html also has two
iframes
> with id; can you fix those to be named as well?

Sure, thanks for the heads-up.

[Inactive, 2014-03-21 15:44:35]

Uploaded fix for geolocation browser_tests at:
https://codereview.chromium.org/208413002/

FYI, the build bot URLs posted here don't work because rietveld messes with the
% encoding and adds "25". If you strip all the "25" in the links, they work.

[Inactive, 2014-03-22 21:07:19]

Committed patchset #16 manually as r169803 (presubmit successful).

[Noel Gordon, 2014-10-09 12:07:20]

I believe this patch caused https://crbug.com/387539 in the field.  Assigning to
arv since Inactive seems gone?