Update several browser_tests / content_browsertests to set iframes' name

Update several browser_tests / content_browsertests to set iframes' name

Update several browser_tests / content_browsertests to set iframes' name.
Previously, these tests were relying on the iframe's name being its id
if the name parameter was unset. However, this behavior is against
specification and other browsers. Blink is going to be updated accordingly
but we need to fix the tests on Chromium-side first before we can land the
Blink change.

BUG=347169
R=jochen@chromium.org, thakis@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255756

[bradnelson, 2014-03-06 19:24:30]

lgtm

[Nico, 2014-03-06 19:30:36]

https://codereview.chromium.org/188813003/diff/1/chrome/test/data/nacl/extens...
File
chrome/test/data/nacl/extension_mime_handler/ppapi_extension_mime_handler.html
(right):

https://codereview.chromium.org/188813003/diff/1/chrome/test/data/nacl/extens...
chrome/test/data/nacl/extension_mime_handler/ppapi_extension_mime_handler.html:10:
var iframe_doc = window.frames['iframe_id'].document;
Huh, does this actually work? I thought window.frames was indexed by 0, 1, etc,
not by the frame's name.

[Inactive, 2014-03-06 19:46:23]

https://codereview.chromium.org/188813003/diff/1/chrome/test/data/nacl/extens...
File
chrome/test/data/nacl/extension_mime_handler/ppapi_extension_mime_handler.html
(right):

https://codereview.chromium.org/188813003/diff/1/chrome/test/data/nacl/extens...
chrome/test/data/nacl/extension_mime_handler/ppapi_extension_mime_handler.html:10:
var iframe_doc = window.frames['iframe_id'].document;
On 2014/03/06 19:30:36, Nico wrote:
> Huh, does this actually work? I thought window.frames was indexed by 0, 1,
etc,
> not by the frame's name.

As per the HTML5 spec, window.frames returns a WindowProxy object and Window has
a named property getter:
http://www.whatwg.org/specs/web-apps/current-work/multipage/browsers.html#dom...

See for e.g. http://jsfiddle.net/xUwmH/3/. This works fine in Chrome, IE and FF.

I should probably rename iframe_id to iframe_name though, to avoid confusion.

[Nico, 2014-03-06 19:49:43]

lgtm, thanks for explaining :-)

https://codereview.chromium.org/188813003/diff/1/chrome/test/data/nacl/extens...
File
chrome/test/data/nacl/extension_mime_handler/ppapi_extension_mime_handler.html
(right):

https://codereview.chromium.org/188813003/diff/1/chrome/test/data/nacl/extens...
chrome/test/data/nacl/extension_mime_handler/ppapi_extension_mime_handler.html:10:
var iframe_doc = window.frames['iframe_id'].document;
On 2014/03/06 19:46:24, Chris Dumez wrote:
> On 2014/03/06 19:30:36, Nico wrote:
> > Huh, does this actually work? I thought window.frames was indexed by 0, 1,
> etc,
> > not by the frame's name.
> 
> As per the HTML5 spec, window.frames returns a WindowProxy object and Window
has
> a named property getter:
>
http://www.whatwg.org/specs/web-apps/current-work/multipage/browsers.html#dom...
> 
> See for e.g. http://jsfiddle.net/xUwmH/3/. This works fine in Chrome, IE and
FF.
> 
> I should probably rename iframe_id to iframe_name though, to avoid confusion.

Yes, that sounds like a good idea.

[Inactive, 2014-03-06 19:50:29]

https://codereview.chromium.org/188813003/diff/1/chrome/test/data/nacl/extens...
File
chrome/test/data/nacl/extension_mime_handler/ppapi_extension_mime_handler.html
(right):

https://codereview.chromium.org/188813003/diff/1/chrome/test/data/nacl/extens...
chrome/test/data/nacl/extension_mime_handler/ppapi_extension_mime_handler.html:10:
var iframe_doc = window.frames['iframe_id'].document;
On 2014/03/06 19:49:44, Nico wrote:
> On 2014/03/06 19:46:24, Chris Dumez wrote:
> > On 2014/03/06 19:30:36, Nico wrote:
> > > Huh, does this actually work? I thought window.frames was indexed by 0, 1,
> > etc,
> > > not by the frame's name.
> > 
> > As per the HTML5 spec, window.frames returns a WindowProxy object and Window
> has
> > a named property getter:
> >
>
http://www.whatwg.org/specs/web-apps/current-work/multipage/browsers.html#dom...
> > 
> > See for e.g. http://jsfiddle.net/xUwmH/3/. This works fine in Chrome, IE and
> FF.
> > 
> > I should probably rename iframe_id to iframe_name though, to avoid
confusion.
> 
> Yes, that sounds like a good idea.

Done.

[Inactive, 2014-03-06 19:52:42]

+brettw for the change to content/browser/frame_host/frame_tree_browsertest.cc
as it seems like jochen is out of office.

[brettw, 2014-03-07 17:44:52]

content lgtm rubberstamp

[Inactive, 2014-03-07 18:41:35]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-03-07 18:44:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/188813003/20001

[commit-bot: I haz the power, 2014-03-07 20:24:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/188813003/20001

[commit-bot: I haz the power, 2014-03-08 10:50:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/188813003/20001

[commit-bot: I haz the power, 2014-03-08 11:44:09]

Change committed as 255756