Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Unified Diff: Source/core/html/HTMLFrameElementBase.cpp

Issue 187103002: id of iframe incorrectly sets window name (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add back no-referrer-subframe.html Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/plugins/plugin-remove-subframe.html ('k') | Source/web/tests/data/iframe_redirect.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLFrameElementBase.cpp
diff --git a/Source/core/html/HTMLFrameElementBase.cpp b/Source/core/html/HTMLFrameElementBase.cpp
index f7e2290e5bfb70381c4f92e571edefc1c39cfd89..37b64ab10f67fb5bbde4f2ff90215927e55bdba5 100644
--- a/Source/core/html/HTMLFrameElementBase.cpp
+++ b/Source/core/html/HTMLFrameElementBase.cpp
@@ -137,8 +137,6 @@ void HTMLFrameElementBase::parseAttribute(const QualifiedName& name, const Atomi
void HTMLFrameElementBase::setNameAndOpenURL()
{
m_frameName = getNameAttribute();
- if (m_frameName.isNull())
- m_frameName = getIdAttribute();
openURL();
}
« no previous file with comments | « LayoutTests/plugins/plugin-remove-subframe.html ('k') | Source/web/tests/data/iframe_redirect.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698