Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1870833004:
Roll breakpad 9992f5d9d..06029285343afc (Closed)
DescriptionRoll breakpad 9992f5d9d..06029285343afc
The following CL rolls breakpad with the following changes:
https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/9992f5d9d..06029285343afc
$ git log 9992f5d9d..06029285343afc --reverse --format='%h %s'
8a41d1d Make EXC_BAD_ACCESS / EXC_I386_GPFLT print nicely in the processor
4044d7e Refactor sym_upload in tools to extract code into common/linux, and minor fixes to code calling libcurl. This change may be used to build a tool to dump and upload symbols with multi-thread.
95e51c6 Add the TID to the CallStack.
a62ccfd Support processing microdump for mips architecture
a67c33f Switch the Linux minidump writer to use MDCVInfoELF for CV data.
2225ad6 Rename stdio.h wrapper file to stdio_wrapper.h.
3cb3449 Remove unreferenced local variable which breaks build.
0602928 Added an option (-i) to have dump_syms output header information only.
R=jochen@chromium.org
BUG=561447
Committed: https://crrev.com/0b715c6d6d79d4e3bb3f4686b2f62400598fe826
Cr-Commit-Position: refs/heads/master@{#386588}
Patch Set 1 #Patch Set 2 : Fixed GN/GYP rules for symupload refactor #Patch Set 3 : Added proper build id's as done on breakpad makefiles #Patch Set 4 : Added breakpad ld flags as a config #Patch Set 5 : Remove default android build-id flag in gyp #
Messages
Total messages: 37 (17 generated)
lgtm
The CQ bit was checked by dyen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870833004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870833004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
dyen@chromium.org changed reviewers: + mark@chromium.org
+mark@ for breakpad gn/gyp file fixes. Looks like this CL added some files for symupload: https://codereview.chromium.org/1842113002
LGTM
The CL description is missing a newline between your shell command and its output.
Description was changed from ========== Roll breakpad 9992f5d9d..06029285343afc The following CL rolls breakpad with the following changes: https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/9992f5d9d..0... $ git log 9992f5d9d..06029285343afc --reverse --format='%h %s'8a41d1d Make EXC_BAD_ACCESS / EXC_I386_GPFLT print nicely in the processor 4044d7e Refactor sym_upload in tools to extract code into common/linux, and minor fixes to code calling libcurl. This change may be used to build a tool to dump and upload symbols with multi-thread. 95e51c6 Add the TID to the CallStack. a62ccfd Support processing microdump for mips architecture a67c33f Switch the Linux minidump writer to use MDCVInfoELF for CV data. 2225ad6 Rename stdio.h wrapper file to stdio_wrapper.h. 3cb3449 Remove unreferenced local variable which breaks build. 0602928 Added an option (-i) to have dump_syms output header information only. R=jochen@chromium.org BUG=561447 ========== to ========== Roll breakpad 9992f5d9d..06029285343afc The following CL rolls breakpad with the following changes: https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/9992f5d9d..0... $ git log 9992f5d9d..06029285343afc --reverse --format='%h %s' 8a41d1d Make EXC_BAD_ACCESS / EXC_I386_GPFLT print nicely in the processor 4044d7e Refactor sym_upload in tools to extract code into common/linux, and minor fixes to code calling libcurl. This change may be used to build a tool to dump and upload symbols with multi-thread. 95e51c6 Add the TID to the CallStack. a62ccfd Support processing microdump for mips architecture a67c33f Switch the Linux minidump writer to use MDCVInfoELF for CV data. 2225ad6 Rename stdio.h wrapper file to stdio_wrapper.h. 3cb3449 Remove unreferenced local variable which breaks build. 0602928 Added an option (-i) to have dump_syms output header information only. R=jochen@chromium.org BUG=561447 ==========
On 2016/04/08 17:26:21, Mark Mentovai wrote: > The CL description is missing a newline between your shell command and its > output. Fixed.
The CQ bit was checked by dyen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org Link to the patchset: https://codereview.chromium.org/1870833004/#ps20001 (title: "Fixed GN/GYP rules for symupload refactor")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870833004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870833004/20001
On 2016/04/08 18:04:44, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > https://chromium-cq-status.appspot.com/patch-status/1870833004/20001 > View timeline at > https://chromium-cq-status.appspot.com/patch-timeline/1870833004/20001 We are getting a unit test failure with the deps roll, does someone know which CL might have caused it? The failed test is MinidumpWriterTest.BuildIDLong on Android.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
On 2016/04/08 19:51:50, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, > https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) Looks like some LD flags were added to get the unittest working. I'll try the CQ again.
The CQ bit was checked by dyen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org, jochen@chromium.org Link to the patchset: https://codereview.chromium.org/1870833004/#ps40001 (title: "Added proper build id's as done on breakpad makefiles")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870833004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870833004/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
dyen@chromium.org changed reviewers: + brettw@chromium.org
+brettw@ for gn hack to override the build-id field. I am pretty sure I did this right but you can take a look if you like.
The CQ bit was checked by dyen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org, jochen@chromium.org Link to the patchset: https://codereview.chromium.org/1870833004/#ps80001 (title: "Remove default android build-id flag in gyp")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870833004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870833004/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by dyen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870833004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870833004/80001
Message was sent while issue was closed.
Description was changed from ========== Roll breakpad 9992f5d9d..06029285343afc The following CL rolls breakpad with the following changes: https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/9992f5d9d..0... $ git log 9992f5d9d..06029285343afc --reverse --format='%h %s' 8a41d1d Make EXC_BAD_ACCESS / EXC_I386_GPFLT print nicely in the processor 4044d7e Refactor sym_upload in tools to extract code into common/linux, and minor fixes to code calling libcurl. This change may be used to build a tool to dump and upload symbols with multi-thread. 95e51c6 Add the TID to the CallStack. a62ccfd Support processing microdump for mips architecture a67c33f Switch the Linux minidump writer to use MDCVInfoELF for CV data. 2225ad6 Rename stdio.h wrapper file to stdio_wrapper.h. 3cb3449 Remove unreferenced local variable which breaks build. 0602928 Added an option (-i) to have dump_syms output header information only. R=jochen@chromium.org BUG=561447 ========== to ========== Roll breakpad 9992f5d9d..06029285343afc The following CL rolls breakpad with the following changes: https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/9992f5d9d..0... $ git log 9992f5d9d..06029285343afc --reverse --format='%h %s' 8a41d1d Make EXC_BAD_ACCESS / EXC_I386_GPFLT print nicely in the processor 4044d7e Refactor sym_upload in tools to extract code into common/linux, and minor fixes to code calling libcurl. This change may be used to build a tool to dump and upload symbols with multi-thread. 95e51c6 Add the TID to the CallStack. a62ccfd Support processing microdump for mips architecture a67c33f Switch the Linux minidump writer to use MDCVInfoELF for CV data. 2225ad6 Rename stdio.h wrapper file to stdio_wrapper.h. 3cb3449 Remove unreferenced local variable which breaks build. 0602928 Added an option (-i) to have dump_syms output header information only. R=jochen@chromium.org BUG=561447 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Roll breakpad 9992f5d9d..06029285343afc The following CL rolls breakpad with the following changes: https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/9992f5d9d..0... $ git log 9992f5d9d..06029285343afc --reverse --format='%h %s' 8a41d1d Make EXC_BAD_ACCESS / EXC_I386_GPFLT print nicely in the processor 4044d7e Refactor sym_upload in tools to extract code into common/linux, and minor fixes to code calling libcurl. This change may be used to build a tool to dump and upload symbols with multi-thread. 95e51c6 Add the TID to the CallStack. a62ccfd Support processing microdump for mips architecture a67c33f Switch the Linux minidump writer to use MDCVInfoELF for CV data. 2225ad6 Rename stdio.h wrapper file to stdio_wrapper.h. 3cb3449 Remove unreferenced local variable which breaks build. 0602928 Added an option (-i) to have dump_syms output header information only. R=jochen@chromium.org BUG=561447 ========== to ========== Roll breakpad 9992f5d9d..06029285343afc The following CL rolls breakpad with the following changes: https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/9992f5d9d..0... $ git log 9992f5d9d..06029285343afc --reverse --format='%h %s' 8a41d1d Make EXC_BAD_ACCESS / EXC_I386_GPFLT print nicely in the processor 4044d7e Refactor sym_upload in tools to extract code into common/linux, and minor fixes to code calling libcurl. This change may be used to build a tool to dump and upload symbols with multi-thread. 95e51c6 Add the TID to the CallStack. a62ccfd Support processing microdump for mips architecture a67c33f Switch the Linux minidump writer to use MDCVInfoELF for CV data. 2225ad6 Rename stdio.h wrapper file to stdio_wrapper.h. 3cb3449 Remove unreferenced local variable which breaks build. 0602928 Added an option (-i) to have dump_syms output header information only. R=jochen@chromium.org BUG=561447 Committed: https://crrev.com/0b715c6d6d79d4e3bb3f4686b2f62400598fe826 Cr-Commit-Position: refs/heads/master@{#386588} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/0b715c6d6d79d4e3bb3f4686b2f62400598fe826 Cr-Commit-Position: refs/heads/master@{#386588} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
