Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2987)

Unified Diff: breakpad/BUILD.gn

Issue 1870833004: Roll breakpad 9992f5d9d..06029285343afc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove default android build-id flag in gyp Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | breakpad/breakpad.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: breakpad/BUILD.gn
diff --git a/breakpad/BUILD.gn b/breakpad/BUILD.gn
index fd8b457c49753e1fb18e52a74507f3d6c75d06d2..7ab4d05172673c28e4bdf2b2c757253dfbea372f 100644
--- a/breakpad/BUILD.gn
+++ b/breakpad/BUILD.gn
@@ -49,6 +49,12 @@ config("sender_config") {
include_dirs = [ "src" ]
}
+config("breakpad_unittest_config") {
+ # One of the breakpad unit tests test that we can detect the proper build-id.
+ # We must override the build-id for this one target.
+ ldflags = [ "-Wl,--build-id=0x000102030405060708090a0b0c0d0e0f101112131415161718191a1b1c1d1e1f" ]
+}
+
# {micro,mini}dump_stackwalk and minidump_dump are tool-type executables
# that do not build on Windows.
if (!is_win) {
@@ -418,6 +424,8 @@ if (is_linux || is_android) {
sources = [
"src/common/linux/http_upload.cc",
"src/common/linux/http_upload.h",
+ "src/common/linux/symbol_upload.cc",
+ "src/common/linux/symbol_upload.h",
"src/tools/linux/symupload/sym_upload.cc",
]
@@ -690,6 +698,9 @@ if (is_linux || is_android) {
# linux_syscall_support.h hand written asm syscalls.
# See https://crbug.com/556393
configs -= [ "//build/config/compiler:clang_stackrealign" ]
+
+ # Add the breakpad unittest config at the end to override all configs.
+ configs += [ ":breakpad_unittest_config" ]
}
executable("linux_dumper_unittest_helper") {
« no previous file with comments | « DEPS ('k') | breakpad/breakpad.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698