Refactor sym_upload in tools to extract code into common/linux, and minor fixes

Refactor sym_upload in tools to extract code into common/linux, and minor fixes
to code calling libcurl. This change may be used to build a tool to dump and
upload symbols with multi-thread.

BUG=

R=mmandlis@chromium.org
CC=google-breakpad-dev@googlegroups.com

Committed: https://chromium.googlesource.com/breakpad/breakpad/+/c77c51fae6796fbe86ecafd6136ef9503251c035

[mmandlis, 2016-03-30 18:34:40]

lgtm

https://codereview.chromium.org/1842113002/diff/1/src/common/linux/symbol_upl...
File src/common/linux/symbol_upload.cc (right):

https://codereview.chromium.org/1842113002/diff/1/src/common/linux/symbol_upl...
src/common/linux/symbol_upload.cc:46: int c, std::vector<string> *results) {
nit, please, fix indentation.

https://codereview.chromium.org/1842113002/diff/1/src/common/linux/symbol_upl...
src/common/linux/symbol_upload.cc:62: std::vector<string> *module_parts) {
nit, please, fix indentation.

[lyan, 2016-03-30 18:40:55]

Both done. Thanks for spotting misaligned.

On 2016/03/30 18:34:40, mmandlis wrote:
> lgtm
> 
>
https://codereview.chromium.org/1842113002/diff/1/src/common/linux/symbol_upl...
> File src/common/linux/symbol_upload.cc (right):
> 
>
https://codereview.chromium.org/1842113002/diff/1/src/common/linux/symbol_upl...
> src/common/linux/symbol_upload.cc:46: int c, std::vector<string> *results) {
> nit, please, fix indentation.
Done.
> 
>
https://codereview.chromium.org/1842113002/diff/1/src/common/linux/symbol_upl...
> src/common/linux/symbol_upload.cc:62: std::vector<string> *module_parts) {
> nit, please, fix indentation.
Done.

[lyan, 2016-03-30 18:43:18]

On 2016/03/30 18:40:55, lyan wrote:
> Both done. Thanks for spotting misaligned.
> 
> On 2016/03/30 18:34:40, mmandlis wrote:
> > lgtm
> > 
> >
>
https://codereview.chromium.org/1842113002/diff/1/src/common/linux/symbol_upl...
> > File src/common/linux/symbol_upload.cc (right):
> > 
> >
>
https://codereview.chromium.org/1842113002/diff/1/src/common/linux/symbol_upl...
> > src/common/linux/symbol_upload.cc:46: int c, std::vector<string> *results) {
> > nit, please, fix indentation.
> Done.
Move int c up to fill the line.
> > 
> >
>
https://codereview.chromium.org/1842113002/diff/1/src/common/linux/symbol_upl...
> > src/common/linux/symbol_upload.cc:62: std::vector<string> *module_parts) {
> > nit, please, fix indentation.
> Done.

[lyan, 2016-03-30 20:25:48]

fixed indentation.

[lyan, 2016-03-30 20:46:23]

Description was changed from

==========
Refactor sym_upload in tools to extract code into common/linux, and minor fixes
to code calling libcurl. This change may be used to build a tool to dump and
upload symbols with multi-thread.

BUG=

R=mmandlis@chromium.org
CC=google-breakpad-dev@googlegroups.com
==========

to

==========
Refactor sym_upload in tools to extract code into common/linux, and minor fixes
to code calling libcurl. This change may be used to build a tool to dump and
upload symbols with multi-thread.

BUG=

R=mmandlis@chromium.org
CC=google-breakpad-dev@googlegroups.com

Committed:
https://chromium.googlesource.com/breakpad/breakpad/+/c77c51fae6796fbe86ecafd...
==========

[lyan, 2016-03-30 20:46:24]

Committed patchset #3 (id:40001) manually as
c77c51fae6796fbe86ecafd6136ef9503251c035 (presubmit successful).