third_party/WebKit/Source/platform/graphics/filters/FilterOperationsTest.cpp - Issue 1870793004: Move common logic between BoxReflectFilterOperation and FEBoxReflect into BoxReflection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FilterOperationsTest.cpp

Issue 1870793004: Move common logic between BoxReflectFilterOperation and FEBoxReflect into BoxReflection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-filter-outsets-2

Patch Set: merge with master Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/FilterOperation.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FilterOperationsTest.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FilterOperationsTest.cpp b/third_party/WebKit/Source/platform/graphics/filters/FilterOperationsTest.cpp

index a51acd76a3b1c580f57e5d675134bf4951736e35..ecb4268d2900615ef701b82061ef489f3bbfaa0f 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FilterOperationsTest.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FilterOperationsTest.cpp

@@ -57,7 +57,8 @@ TEST(FilterOperationsTest, mapRectDropShadow)

TEST(FilterOperationsTest, mapRectBoxReflect)

{

FilterOperations ops;

- ops.operations().append(BoxReflectFilterOperation::create(VerticalReflection, 100));

+ ops.operations().append(BoxReflectFilterOperation::create(

+ BoxReflection(BoxReflection::VerticalReflection, 100)));

EXPECT_TRUE(ops.hasFilterThatMovesPixels());

// original IntRect(0, 0, 10, 10) + reflection IntRect(90, 90, 10, 10)

@@ -70,7 +71,8 @@ TEST(FilterOperationsTest, mapRectDropShadowAndBoxReflect)

// important that the bounds be filtered in the correct order.

FilterOperations ops;

ops.operations().append(DropShadowFilterOperation::create(IntPoint(100, 200), 0, Color::black));

- ops.operations().append(BoxReflectFilterOperation::create(VerticalReflection, 50));

+ ops.operations().append(BoxReflectFilterOperation::create(

+ BoxReflection(BoxReflection::VerticalReflection, 50)));

EXPECT_TRUE(ops.hasFilterThatMovesPixels());

EXPECT_EQ(FloatRect(0, -160, 110, 370),

ops.mapRect(FloatRect(0, 0, 10, 10)));