third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h - Issue 1870793004: Move common logic between BoxReflectFilterOperation and FEBoxReflect into BoxReflection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h

Issue 1870793004: Move common logic between BoxReflectFilterOperation and FEBoxReflect into BoxReflection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-filter-outsets-2

Patch Set: merge with master Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/FilterOperationsTest.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h

diff --git a/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h b/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h

index efbcdf556f20d92d439f5cc1be52ba8ba0ed6fcd..bfcdb7d2591510bc359ad5d3cd937c0845546cc6 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h

+++ b/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h

@@ -34,11 +34,11 @@

#include "platform/heap/Handle.h"

class SkImageFilter;

-class SkMatrix;

namespace blink {

class AffineTransform;

+class BoxReflection;

class FilterEffect;

class FilterOperations;

class Image;

@@ -55,9 +55,7 @@ public:

PassRefPtr<SkImageFilter> transformColorSpace(

SkImageFilter* input, ColorSpace srcColorSpace, ColorSpace dstColorSpace);

- SkMatrix matrixForBoxReflectFilter(ReflectionDirection, float offset);

- PassRefPtr<SkImageFilter> buildBoxReflectFilter(

- ReflectionDirection, float offset, Image* maskImage, SkImageFilter* input);

+ PassRefPtr<SkImageFilter> buildBoxReflectFilter(const BoxReflection&, PassRefPtr<SkImageFilter> input);

};

} // namespace blink