Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FilterOperation.cpp

Issue 1870793004: Move common logic between BoxReflectFilterOperation and FEBoxReflect into BoxReflection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-filter-outsets-2
Patch Set: merge with master Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/filters/FilterOperation.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/filters/FilterOperation.cpp b/third_party/WebKit/Source/platform/graphics/filters/FilterOperation.cpp
index 46baef0e81fa79bd1fb24ffff396bed38134c842..46165337c1ebea32cb942e1670411609335afc57 100644
--- a/third_party/WebKit/Source/platform/graphics/filters/FilterOperation.cpp
+++ b/third_party/WebKit/Source/platform/graphics/filters/FilterOperation.cpp
@@ -192,17 +192,7 @@ FilterOperation* DropShadowFilterOperation::blend(const FilterOperation* from, d
FloatRect BoxReflectFilterOperation::mapRect(const FloatRect& rect) const
{
- // Reflection about any line is self-inverse, so this matrix works for both
- // forward and reverse mapping.
- SkMatrix flipMatrix = SkiaImageFilterBuilder().matrixForBoxReflectFilter(
- m_direction, m_offset);
-
- SkRect reflection(rect);
- flipMatrix.mapRect(&reflection);
-
- FloatRect result = rect;
- result.unite(reflection);
- return result;
+ return m_reflection.mapRect(rect);
}
FilterOperation* BoxReflectFilterOperation::blend(const FilterOperation* from, double progress) const
@@ -216,7 +206,7 @@ bool BoxReflectFilterOperation::operator==(const FilterOperation& o) const
if (!isSameType(o))
return false;
const auto& other = static_cast<const BoxReflectFilterOperation&>(o);
- return m_direction == other.m_direction && m_offset == other.m_offset;
+ return m_reflection == other.m_reflection;
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698