Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FilterOperation.h

Issue 1870793004: Move common logic between BoxReflectFilterOperation and FEBoxReflect into BoxReflection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-filter-outsets-2
Patch Set: merge with master Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/filters/FilterOperation.h
diff --git a/third_party/WebKit/Source/platform/graphics/filters/FilterOperation.h b/third_party/WebKit/Source/platform/graphics/filters/FilterOperation.h
index e9bd90d020fe0c239be923ddf9cb10acb10ad489..2d33ec109f959a77a8377b0f649820cf987aaf91 100644
--- a/third_party/WebKit/Source/platform/graphics/filters/FilterOperation.h
+++ b/third_party/WebKit/Source/platform/graphics/filters/FilterOperation.h
@@ -28,8 +28,8 @@
#include "platform/Length.h"
#include "platform/PlatformExport.h"
+#include "platform/graphics/BoxReflection.h"
#include "platform/graphics/Color.h"
-#include "platform/graphics/GraphicsTypes.h"
#include "platform/graphics/filters/Filter.h"
#include "platform/heap/Handle.h"
#include "wtf/Noncopyable.h"
@@ -322,13 +322,12 @@ DEFINE_FILTER_OPERATION_TYPE_CASTS(DropShadowFilterOperation, DROP_SHADOW);
class PLATFORM_EXPORT BoxReflectFilterOperation : public FilterOperation {
public:
- static BoxReflectFilterOperation* create(ReflectionDirection direction, float offset)
+ static BoxReflectFilterOperation* create(const BoxReflection& reflection)
{
- return new BoxReflectFilterOperation(direction, offset);
+ return new BoxReflectFilterOperation(reflection);
}
- ReflectionDirection direction() const { return m_direction; }
- float offset() const { return m_offset; }
+ const BoxReflection& reflection() const { return m_reflection; }
bool affectsOpacity() const override { return true; }
bool movesPixels() const override { return true; }
@@ -338,15 +337,13 @@ private:
FilterOperation* blend(const FilterOperation* from, double progress) const override;
bool operator==(const FilterOperation&) const override;
- BoxReflectFilterOperation(ReflectionDirection direction, float offset)
+ BoxReflectFilterOperation(const BoxReflection& reflection)
: FilterOperation(BOX_REFLECT)
- , m_direction(direction)
- , m_offset(offset)
+ , m_reflection(reflection)
{
}
- ReflectionDirection m_direction;
- float m_offset;
+ BoxReflection m_reflection;
};
DEFINE_FILTER_OPERATION_TYPE_CASTS(BoxReflectFilterOperation, BOX_REFLECT);

Powered by Google App Engine
This is Rietveld 408576698