Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 1870723002: MD Settings: Polish Language settings (update strings) (Closed)

Created:
4 years, 8 months ago by michaelpg
Modified:
4 years, 8 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@LanguagePolish
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Polish Language settings (update strings) BUG=512479 R=dschuyler@chromium.org Committed: https://crrev.com/6338f297e1f07a672d6c09c28a5a585d3f6ef003 Cr-Commit-Position: refs/heads/master@{#386910}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Language string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M chrome/app/settings_strings.grdp View 1 3 chunks +15 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (2 generated)
dschuyler
There's some chance that one (or both) of us is looking at out of date ...
4 years, 8 months ago (2016-04-07 21:17:58 UTC) #1
michaelpg
https://codereview.chromium.org/1870723002/diff/1/chrome/app/settings_strings.grdp File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/1870723002/diff/1/chrome/app/settings_strings.grdp#newcode577 chrome/app/settings_strings.grdp:577: Language and Input On 2016/04/07 21:17:58, dschuyler wrote: > ...
4 years, 8 months ago (2016-04-07 23:13:38 UTC) #2
michaelpg
PTAL. I'm sure this isn't the last time we'll be updating these but hopefully these ...
4 years, 8 months ago (2016-04-08 19:09:09 UTC) #3
dschuyler
lgtm
4 years, 8 months ago (2016-04-11 18:16:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870723002/20001
4 years, 8 months ago (2016-04-13 02:35:18 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-13 03:17:18 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 03:18:39 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6338f297e1f07a672d6c09c28a5a585d3f6ef003
Cr-Commit-Position: refs/heads/master@{#386910}

Powered by Google App Engine
This is Rietveld 408576698